feat(communities): enable selecting addresses to pass when joining #3656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
jrainville
commented
Jun 21, 2023
There was a problem hiding this comment.
I improved the utils functions in this test to accept passing multiple addresses. That enabled me to create the new test that verifies that when passing an address in the request, we indeed only receive that address in the owner's messenger.
Jenkins Builds
|
0x-r4bbit
approved these changes
Jun 22, 2023
|
|
||
| type RequestToJoinCommunity struct { | ||
| CommunityID types.HexBytes `json:"communityId"` | ||
| ENSName string `json:"ensName"` | ||
| Password string `json:"password"` | ||
| Addresses []string `json:"addresses"` |
There was a problem hiding this comment.
How do you think about calling this AddressesToReveal ?
| continue | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Just another way to do it, but would be cool if we could change the check to something like
if wantsToRevealWalletAddress := addressToRevealMap[walletAccount.Address.Hex()]; hasAddressesToReveal && wantsToRevealWalletAddress {
...
}
There was a problem hiding this comment.
or for more readiness:
if len(request.Addresses) > 0 && !containsAddress(request.Addresses, walletAccount.Address.Hex()) {
continue
}
func containsAddress(addresses []string, targetAddress string) bool {
for _, address := range addresses {
if address == targetAddress {
return true
}
}
return false
}
mprakhov
approved these changes
Jun 22, 2023
Improve `RequestToJoinCommunity` to accept `Addresses` in the request. If `Addresses` is not empty, we then only pass to the owner the selected addresses. The others are ignored. Does not validate that the addresses in the slice are part of the user's wallet. Those not part of the wallet are just ignored.
jrainville
force-pushed
the
feat/pass-selected-addresses-join-api
branch
from
1011b17 to
8ead8e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for status-im/status-desktop#11154
Improves
RequestToJoinCommunityto acceptAddressesin the request. IfAddressesis not empty, we then only pass to the owner the selected addresses. The others are ignored. Does not validate that the addresses in the slice are part of the user's wallet. Those not part of the wallet are just ignored.