feat(requestToJoin): add addressesToShare to requestToJoin call #11224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrainville
requested review from
a team,
iurimatias,
richard-ramos,
0x-r4bbit and
osmaczko
and removed request for
a team
Jenkins BuildsClick to see older builds (20)
|
jrainville
force-pushed
the
feat/select-shared-address
branch
from
814d809 to
25aa3ab
Compare
0x-r4bbit
approved these changes
Jun 26, 2023
| @@ -192,7 +194,7 @@ proc init*(self: Controller) = | |||
| let args = SharedKeycarModuleArgs(e) | |||
| if args.uniqueIdentifier != UNIQUE_MAIN_MODULE_AUTH_IDENTIFIER: | |||
| return | |||
| if self.tmpRequestToJoinCommunityId == self.sectionId: | |||
| if self.tmpAuthenticationForJoinInProgress == true: | |||
There was a problem hiding this comment.
Suggested change
| if self.tmpAuthenticationForJoinInProgress == true: | |
| if self.tmpAuthenticationForJoinInProgress: |
jrainville
force-pushed
the
feat/select-shared-address
branch
2 times, most recently
from
49684a6 to
f580fc2
Compare
|
@osmaczko reminder to review please :) |
jrainville
force-pushed
the
feat/select-shared-address
branch
from
f580fc2 to
c5ed241
Compare
|
@osmaczko 🙏 🙏 🙏 🙏 🙏 |
6 tasks
osmaczko
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11154
Adds the Nim code and status-go code to enable passing the user's wanted addresses, instead of using all addresses.
Status-go PR status-im/status-go#3656
The new view function is
When
addressesToShareis a stringified array of string addresses.