Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use go 1.19 and bump go-libp2p #3371

Merged
merged 3 commits into from
Apr 7, 2023
Merged

Conversation

richard-ramos
Copy link
Member

No description provided.

@richard-ramos richard-ramos requested a review from jakubgs April 3, 2023 14:56
@ghost
Copy link

ghost commented Apr 3, 2023

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?
  • Have you tested changes with mobile?
  • Have you tested changes with desktop?

@status-im-auto
Copy link
Member

status-im-auto commented Apr 3, 2023

Jenkins Builds

Click to see older builds (19)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ b805737 #1 2023-04-03 14:57:59 ~1 min linux 📦zip
b805737 #1 2023-04-03 14:58:43 ~2 min ios 📄log
b805737 #1 2023-04-03 14:59:10 ~2 min android 📄log
✖️ b805737 #1 2023-04-03 14:59:40 ~3 min tests 📄log
97eb057 #2 2023-04-03 15:04:45 ~36 sec ios 📄log
97eb057 #2 2023-04-03 15:04:57 ~47 sec android 📄log
✔️ 97eb057 #2 2023-04-03 15:05:02 ~51 sec linux 📦zip
✖️ 97eb057 #2 2023-04-03 15:05:11 ~1 min tests 📄log
✔️ fc6381c #3 2023-04-03 15:12:22 ~58 sec linux 📦zip
✔️ fc6381c #3 2023-04-03 15:15:58 ~4 min ios 📦zip
✔️ fc6381c #3 2023-04-03 15:16:51 ~5 min android 📦aar
✖️ fc6381c #3 2023-04-03 15:35:39 ~24 min tests 📄log
✔️ e765e62 #4 2023-04-03 15:38:05 ~56 sec linux 📦zip
✔️ e765e62 #4 2023-04-03 15:39:58 ~2 min ios 📦zip
✔️ e765e62 #4 2023-04-03 15:40:22 ~3 min android 📦aar
✖️ e765e62 #4 2023-04-03 15:59:32 ~22 min tests 📄log
✖️ e765e62 #5 2023-04-03 16:41:02 ~21 min tests 📄log
✖️ e765e62 #6 2023-04-03 17:28:55 ~20 min tests 📄log
✖️ e765e62 #7 2023-04-03 18:16:36 ~20 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 032d0ab #5 2023-04-04 18:29:46 ~3 min ios 📦zip
✔️ 032d0ab #5 2023-04-04 18:30:33 ~3 min android 📦aar
✔️ 032d0ab #5 2023-04-04 18:31:39 ~4 min linux 📦zip
✖️ 032d0ab #8 2023-04-04 18:48:31 ~21 min tests 📄log
✔️ 3113348 #6 2023-04-07 18:12:38 ~3 min linux 📦zip
✔️ 3113348 #6 2023-04-07 18:12:49 ~3 min ios 📦zip
✔️ 3113348 #6 2023-04-07 18:14:21 ~4 min android 📦aar
✔️ 3113348 #9 2023-04-07 18:21:54 ~12 min tests 📄log

@richard-ramos richard-ramos force-pushed the bump/go-and-go-libp2p branch from fc6381c to e765e62 Compare April 3, 2023 15:36
@richard-ramos richard-ramos force-pushed the bump/go-and-go-libp2p branch from e765e62 to 032d0ab Compare April 4, 2023 18:26
@richard-ramos richard-ramos force-pushed the bump/go-and-go-libp2p branch from 032d0ab to 3113348 Compare April 7, 2023 18:09
@jakubgs jakubgs merged commit ba1ba1a into develop Apr 7, 2023
@jakubgs jakubgs deleted the bump/go-and-go-libp2p branch April 7, 2023 18:23
@siddarthkay
Copy link
Contributor

siddarthkay commented Apr 10, 2023

make run-android STATUS_GO_SRC_OVERRIDE=path/to/status-go fails for me on my linux machine with :

+ exitHandler
+ exitCode=1
+ set +e
+ '[' -n '' ']'
+ ((  1 != 0  ))
+ runHook failureHook
+ local hookName=failureHook
+ shift
+ local 'hooksSlice=failureHooks[@]'
+ local hook
+ for hook in "_callImplicitHook 0 $hookName" ${!hooksSlice+"${!hooksSlice}"}
+ _eval '_callImplicitHook 0 failureHook'
+ declare -F '_callImplicitHook 0 failureHook'
+ eval '_callImplicitHook 0 failureHook'
++ _callImplicitHook 0 failureHook
++ local def=0
++ local hookName=failureHook
++ declare -F failureHook
++ type -p failureHook
++ '[' -n '' ']'
++ return 0
+ return 0
+ '[' -n '' ']'
+ return 1
error: builder for '/nix/store/y0q8bfdccy30ikrilh08a6f3v5igdmpz-status-go-develop-unknown-android.drv' 
failed with exit code 1;
       last 10 log lines:
       > ++ _callImplicitHook 0 failureHook
       > ++ local def=0
       > ++ local hookName=failureHook
       > ++ declare -F failureHook
       > ++ type -p failureHook
       > ++ '[' -n '' ']'
       > ++ return 0
       > + return 0
       > + '[' -n '' ']'
       > + return 1
       For full logs, run 'nix log /nix/store/y0q8bfdccy30ikrilh08a6f3v5igdmpz-status-go-develop-unknown-android.drv'.

probably related to this commit

@siddarthkay
Copy link
Contributor

siddarthkay commented Apr 10, 2023

Error message worth focusing on looks like this :

/nix/store/rydd9xxb3bmzhqiyr88665nnrimnq8lh-gomobile-unstable-2022-05-18/bin/gomobile: 
go build -tags gowaku_skip_migrations -ldflags -X github.com/status-im/status-go/params.GitCommit=unknown 
-X github.com/status-im/status-go/params.IpfsGatewayURL=https://ipfs.status.im/ -X 
github.com/status-im/status-go/params.Version=develop -s -w -buildmode=c-shared 
-o=/build/gomobile-work/android/src/main/jniLibs/armeabi-v7a/libgojni.so ./gobind failed: 
exit status>
# github.com/status-im/status-go/vendor/github.com/quic-go/quic-go/internal/qtls
../../go/src/github.com/status-im/status-go/vendor/github.com/quic-go/quic-go/internal/qtls/
go_oldversion.go:5:13: cannot use 
"The version of quic-go you're using can't be built using outdated Go versions. 
For more details, please see https://github.com/quic-go/quic-go/wiki/quic-go-and-Go-versions." 
(untyped string constant "The version of quic-go you're using can't be built using outdated Go...) 
as int value in variable declaration


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants