Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bumped libp2p and pubsub to 0.32.2 and 0.10 respectively #987

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

chaitanyaprem
Copy link
Collaborator

@chaitanyaprem chaitanyaprem commented Jan 3, 2024

Description

Noticed there is already another PR #851 to bump libp2p to 0.32.0.

Not sure which one to take forward though. Looks like we can take this forward as this also needs updating https://github.com/waku-org/go-libp2p-rendezvous

WDYT @richard-ramos

@status-im-auto
Copy link

status-im-auto commented Jan 3, 2024

Jenkins Builds

Click to see older builds (6)
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ 0dec320 #1 2024-01-03 10:04:33 ~31 sec nix-flake 📄log
✖️ 9226a38 #2 2024-01-11 16:31:00 ~14 sec nix-flake 📄log
✖️ 0a4864f #3 2024-01-11 16:33:18 ~12 sec nix-flake 📄log
✖️ ec658af #4 2024-01-11 16:34:03 ~12 sec nix-flake 📄log
✔️ 7d68462 #5 2024-01-12 16:31:15 ~2 min nix-flake 📄log
✔️ 2a654ee #6 2024-01-12 16:37:30 ~1 min nix-flake 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 56cccfd #7 2024-01-12 16:39:25 ~1 min nix-flake 📄log
✔️ e38d9d7 #8 2024-01-12 17:30:36 ~2 min nix-flake 📄log

@richard-ramos
Copy link
Member

I created the following PR just to test if we'd run into issues:
status-im/status-go#4522 (it includes this commit from #857 to downgrade to go 1.19), but it still fails because go-libp2p now requires go 1.20

[2024-01-03T21:58:36.191Z] vendor/github.com/quic-go/quic-go/internal/qtls/go_oldversion.go:5:13: cannot use "The version of quic-go you're using can't be built using outdated Go versions. For more details, please see https://github.com/quic-go/quic-go/wiki/quic-go-and-Go-versions." (untyped string constant "The version of quic-go you're using can't be built using outdated Go...) as int value in variable declaration
[2024-01-03T21:58:36.191Z] note: module requires Go 1.20

So, looks like we gotta update status-go to use Go 1.20 just like it was done with 1.19 here: status-im/status-go#3371 I'll try that

@richard-ramos
Copy link
Member

richard-ramos commented Jan 3, 2024

Now with go 1.20, there's a more concerning error in the build for android:

[2024-01-03T22:11:27.888Z] unable to import bind/java: [-: # golang.org/x/mobile/bind/java

[2024-01-03T22:11:27.888Z] /nix/store/njgsm9h0wscli413vg98f76yx09crg8z-gomobile-unstable-2022-05-18/src/golang.org/x/mobile/bind/java/context_android.go:9:10: fatal error: jni.h: No such file or directory

[2024-01-03T22:11:27.888Z]     9 | //#include <jni.h>

[2024-01-03T22:11:27.888Z]       |          ^~~~~~~

[2024-01-03T22:11:27.888Z] compilation terminated.]

[2024-01-03T22:11:27.888Z] /nix/store/njgsm9h0wscli413vg98f76yx09crg8z-gomobile-unstable-2022-05-18/bin/gomobile: /nix/store/njgsm9h0wscli413vg98f76yx09crg8z-gomobile-unstable-2022-05-18/bin/gobind -lang=go,java -outdir=/home/jenkins/workspace/status-go_prs_android_PR-4522@tmp/gomobile-work -tags=gowaku_no_rln github.com/status-im/status-go/mobile failed: exit status 1

According to this comment, it works with go 1.21 golang/go#58426 (comment) so lets try that!

@richard-ramos
Copy link
Member

I couldnt update to go1.21. Will continue troubleshooting in PR status-im/status-go#4522

@richard-ramos
Copy link
Member

Btw, if we want to use this PR, we also must take into account the discussion in #851 (comment) about dropping support to mplex in js-waku and nwaku.

@chaitanyaprem
Copy link
Collaborator Author

Btw, if we want to use this PR, we also must take into account the discussion in #851 (comment) about dropping support to mplex in js-waku and nwaku.

Not necessary, because we can still use mplex by specifying it as an option. And the package still exists and can be imported from a different path. But, my suggestion there was to eventually move away from mplex and only use yamux which can be done once all clients remove mplex support.

@richard-ramos richard-ramos force-pushed the chore/bump-libp2p branch 2 times, most recently from 9226a38 to 0a4864f Compare January 11, 2024 16:32
@richard-ramos
Copy link
Member

Just rebased and updated the PR to include go-libp2p-rendezvous. I was able to get status-go to work with 1.20 in status-im/status-go#4522, so we can merge this PR!

@richard-ramos richard-ramos marked this pull request as ready for review January 11, 2024 16:34
@richard-ramos richard-ramos self-requested a review as a code owner January 11, 2024 16:34
@richard-ramos richard-ramos force-pushed the chore/bump-libp2p branch 2 times, most recently from 2a654ee to 56cccfd Compare January 12, 2024 16:35
@richard-ramos richard-ramos merged commit faf046e into master Jan 12, 2024
12 checks passed
@richard-ramos richard-ramos deleted the chore/bump-libp2p branch January 12, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants