-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bumped libp2p and pubsub to 0.32.2 and 0.10 respectively #987
Conversation
Jenkins BuildsClick to see older builds (6)
|
I created the following PR just to test if we'd run into issues:
So, looks like we gotta update status-go to use Go 1.20 just like it was done with 1.19 here: status-im/status-go#3371 I'll try that |
Now with go 1.20, there's a more concerning error in the build for android:
According to this comment, it works with go 1.21 golang/go#58426 (comment) so lets try that! |
I couldnt update to go1.21. Will continue troubleshooting in PR status-im/status-go#4522 |
Btw, if we want to use this PR, we also must take into account the discussion in #851 (comment) about dropping support to mplex in js-waku and nwaku. |
Not necessary, because we can still use mplex by specifying it as an option. And the package still exists and can be imported from a different path. But, my suggestion there was to eventually move away from mplex and only use yamux which can be done once all clients remove mplex support. |
9226a38
to
0a4864f
Compare
0a4864f
to
ec658af
Compare
Just rebased and updated the PR to include go-libp2p-rendezvous. I was able to get status-go to work with 1.20 in status-im/status-go#4522, so we can merge this PR! |
2a654ee
to
56cccfd
Compare
56cccfd
to
e38d9d7
Compare
Description
Noticed there is already another PR #851 to bump libp2p to 0.32.0.
Not sure which one to take forward though. Looks like we can take this forward as this also needs updating https://github.com/waku-org/go-libp2p-rendezvous
WDYT @richard-ramos