feature: support url unfurling settings #12441
Conversation
Jenkins BuildsClick to see older builds (7)
|
|
Sooo, I made a mistake in my status-im/status-go#4128: after rebasing I didn't change the timestamp of my migration. So I merged a migration with timestamp And I also got "lucky" that the newer migrations were merged to status-desktop earlier than this PR: This affected a few users (@alexjba @endulab) who migrated their test accounts before I got this PR merged. Because this doesn't affect a release, and only 2 days (which were weekends) passed since then, I think we shouldn't bother about this. This PR should be merged ASAP before more users face the bug. UPD: For the ones who want to fix their databases, please, run the migration manually: ALTER TABLE settings ADD COLUMN url_unfurling_mode INT NOT NULL DEFAULT 1;
ALTER TABLE settings_sync_clock ADD COLUMN url_unfurling_mode INT NOT NULL DEFAULT 0; |
| @@ -71,7 +71,12 @@ Loader { | |||
| return [] | |||
| const separator = " " | |||
| const arr = links.split(separator) | |||
| const filtered = arr.filter(v => v.toLowerCase().endsWith('.gif')) | |||
| const filtered = arr.filter(value => { | |||
There was a problem hiding this comment.
I'm leaving this here for the record. I think it can also be fixed in another PR where we clean old settings. There's a conflict between the new/old settings.
E.g. GIF enabled in the new settings and disabled in the old settings:
There was a problem hiding this comment.
yeah, I'm working on settings clean-up now, it will be there 👌
Closes #10866
Partially implements #12397 (I will remove the old settings and rearrange things in a separate PR not to mess things around)
backend implemented here: status-im/status-go#4128
What does the PR do
UrlUnfurlingModesettinggifUnfurlingEnabledlocal settingenumHere I didn't bind the UI settings card to the new
UrlUnfurlingMode, @alexjba will take that part (I'll open an issue)