-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new unfurling setting to change if senders want to fetch Link data when sending messages #10866
Comments
Nope, I got no such thing. Also, and at first glance, I wouldn't say that URL unfurling to display an OG image/preview is same as decoding an encoded URL as per vacp2p/rfc#602 and using its metadata/description or the public key to fetch the latest data. |
@felicio my bad, I mentioned the wrong person haha. Too many URL issues today got me confused 😵💫 |
backend task: status-im/status-go#4130 |
Description
Related to #10863
Currently, it's the receivers that fetch the data from links, but with the new feature added with the issue above, it's the sender that will fetch the data and send it with the message.
This issue is to add a setting in the Messaging section. Above
Display Message Link Previews
, add a setting to enable or disable that fetch.Feel free to find a name for it or ask designers for one.
There might already be a setting in status-go for that. You can ask @ilmotta for it.
If there is not, then you can just use a QT setting instead for simplicity
This issue is gonna be easier to implement once #10863 is done, but it can be implemented parallel or before, especially if the setting is already in status-go.
It's also possible that #10863 depends on that setting, but we can hardcode it when working on it, so it's not 100% necessary to have it.
Acceptance Criteria
The text was updated successfully, but these errors were encountered: