Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new unfurling setting to change if senders want to fetch Link data when sending messages #10866

Closed
jrainville opened this issue May 30, 2023 · 3 comments · Fixed by #12441
Assignees
Labels
E:Desktop New Unfurling API Implementation of the new unfurling API for all links feature
Milestone

Comments

@jrainville
Copy link
Member

jrainville commented May 30, 2023

Description

Related to #10863

Currently, it's the receivers that fetch the data from links, but with the new feature added with the issue above, it's the sender that will fetch the data and send it with the message.

This issue is to add a setting in the Messaging section. Above Display Message Link Previews, add a setting to enable or disable that fetch.

Feel free to find a name for it or ask designers for one.

There might already be a setting in status-go for that. You can ask @ilmotta for it.
If there is not, then you can just use a QT setting instead for simplicity

This issue is gonna be easier to implement once #10863 is done, but it can be implemented parallel or before, especially if the setting is already in status-go.
It's also possible that #10863 depends on that setting, but we can hardcode it when working on it, so it's not 100% necessary to have it.

Acceptance Criteria

  • There is a new switch setting in the Messaging section that enables and disables the fetching and sending of data from links
  • When the setting is ON, the feature to fetch and send link data with messages is activated.
  • When the setting is OFF, that feature is deactivated, meaning there is NO fetch (no call to status-go and the web when typing a link) and no additional data sent with the message; ie the link is sent bare and the receiver will NOT have an unfurl, at least after Support new URL unfurling APIs #10863 is implemented
@felicio
Copy link

felicio commented May 30, 2023

There might already be a setting in status-go for that. You can ask @felicio for it.

Nope, I got no such thing.

Also, and at first glance, I wouldn't say that URL unfurling to display an OG image/preview is same as decoding an encoded URL as per vacp2p/rfc#602 and using its metadata/description or the public key to fetch the latest data.

@jrainville
Copy link
Member Author

@felicio my bad, I mentioned the wrong person haha. Too many URL issues today got me confused 😵‍💫

@iurimatias iurimatias modified the milestones: 0.14, 0.15 Jun 13, 2023
@jrainville jrainville added E:Desktop New Share URL Format Implementation of the new share URL link format and other deep link associated issues E:Desktop New Unfurling API Implementation of the new unfurling API for all links and removed E:Desktop New Share URL Format Implementation of the new share URL link format and other deep link associated issues labels Jul 13, 2023
@jrainville jrainville moved this to Next Iteration in Status Desktop/Mobile Board Aug 21, 2023
@jrainville jrainville moved this from Next Iteration to Iteration Backlog in Status Desktop/Mobile Board Aug 23, 2023
@igor-sirotin igor-sirotin moved this from Iteration Backlog to In Progress in Status Desktop/Mobile Board Oct 2, 2023
@igor-sirotin igor-sirotin moved this from In Progress to Code review in Status Desktop/Mobile Board Oct 10, 2023
@igor-sirotin
Copy link
Contributor

backend task: status-im/status-go#4130

@igor-sirotin igor-sirotin moved this from Code review to In Progress in Status Desktop/Mobile Board Oct 10, 2023
@igor-sirotin igor-sirotin moved this from In Progress to Code review in Status Desktop/Mobile Board Oct 13, 2023
@github-project-automation github-project-automation bot moved this from Code review to Done in Status Desktop/Mobile Board Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:Desktop New Unfurling API Implementation of the new unfurling API for all links feature
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants