-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support new URL unfurling APIs #10863
Comments
@jrainville |
Not yet, we can add that in a later PR, it's related to "opting out of sending the individual link data, ie choosing which links to send data for (this will need the updated design)"
Not yet |
Related UI task: #10585 (@igor-sirotin wanna take it too? ;) |
@caybro surely I could! Whoever works on this, probably better to divide the task into:
The first one can already be started to work. |
That new unfurling component (#10585) is out of the scope of this issue. It's the point I list above
Since it's listed as 0.15, let's keep it that way for now. |
Moved step 2 to a separate issue: |
Description
The mobile team created a new API to get the unfurling data from URLs. Instead of having the receiver fetch the data from the websites, it's the sender that fetches it, then sends it with the message. It's way better for privacy, but it also enables more websites to be unfurled.
Here is the initial work with the new APIs: status-im/status-go#3471
Here is the follow up PR that adds support to more hosts: status-im/status-go#3530
For full context, here is the mobile issue: status-im/status-mobile#15469
and follow up one: status-im/status-mobile#15918
If your need help, you can ask @ilmotta , who did an amazing job on this.
Steps
Step 1
So, the first step, is that when typing the message, when we detect a link in the input (with a debounce throttle), we call the new status-go API to get the link data.
Then, when we send the message, we need to add the data to the message payload. It should also already be supported on status-go.
Step 2
Moved to a separate issue:
Out of scope
Acceptance Criteria
The text was updated successfully, but these errors were encountered: