Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/restore old gifs unfurling #11977

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Conversation

igor-sirotin
Copy link
Contributor

@igor-sirotin igor-sirotin commented Aug 21, 2023

Requires:

What does the PR do

Because the new unfurling doesn't yet support GIFs, I've reincarnated old local unfurling. For GIFs only.

Screenshot of functionality (including design for comparison)

Screen.Recording.2023-08-21.at.23.12.46.mov

@status-im-auto
Copy link
Member

status-im-auto commented Aug 21, 2023

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e8dbea8 #1 2023-08-21 20:23:22 ~4 min tests/imports 📄log
✔️ e8dbea8 #1 2023-08-21 20:24:16 ~5 min tests/nim 📄log
✔️ e8dbea8 #1 2023-08-21 20:25:49 ~7 min macos/aarch64 🍎dmg
✔️ e8dbea8 #1 2023-08-21 20:31:33 ~12 min macos/x86_64 🍎dmg
e8dbea8 #1 2023-08-21 20:32:01 ~13 min linux/x86_64 📄log
✔️ e8dbea8 #1 2023-08-21 20:49:06 ~30 min tests/e2e 📄log
✔️ e8dbea8 #1 2023-08-21 20:50:17 ~31 min windows/x86_64 💿exe
✔️ 6205264 #2 2023-08-22 11:23:55 ~4 min tests/imports 📄log
✔️ 6205264 #2 2023-08-22 11:25:01 ~5 min macos/aarch64 🍎dmg
✔️ 6205264 #2 2023-08-22 11:25:05 ~5 min tests/nim 📄log
✔️ 6205264 #2 2023-08-22 11:26:48 ~7 min macos/x86_64 🍎dmg
✔️ 6205264 #2 2023-08-22 11:33:42 ~14 min linux/x86_64 📦tgz
✔️ 6205264 #2 2023-08-22 11:43:52 ~24 min windows/x86_64 💿exe
✔️ 6205264 #2 2023-08-22 11:49:44 ~30 min tests/e2e 📄log

Copy link
Contributor

@MishkaRogachev MishkaRogachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Just a few minor questions

@igor-sirotin igor-sirotin force-pushed the feat/restore-old-gifs-unfurling branch from e8dbea8 to 6205264 Compare August 22, 2023 11:18
@jrainville jrainville merged commit 7e34260 into master Aug 22, 2023
@jrainville jrainville deleted the feat/restore-old-gifs-unfurling branch August 22, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants