-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support unfurl images #11940
feat: Support unfurl images #11940
Conversation
Jenkins BuildsClick to see older builds (7)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Any chance that we could support the old way of unfurling Gifs and Status Links until it is supported on status-go? We still have the settings so it shouldn't be a privacy issue.
Hopefully, it's just a Loader with a simple condition to use an old component instead?
I think it should be possible. I haven't yet dropped the old code 🫣 Will try to reincarnate that in a separate PR. |
13ac28d
to
16b664e
Compare
16b664e
to
0c4d5b4
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
Closes #11634
Requires status-im/status-go#3901
What does the PR do
This PR adds support for new
type
property of link preview.Image URLs are now unfurled again 🪄
Some bad news
Copy/Open Link
instead ofCopy/Download Image
.But currently
StatusImageModal
is taking a wholeImage
component as an argument, so there's no "good" way of passing the link as well. This might require some refactoring. For now the URL in the text itself can still be clicked.Affected areas
Chat URL previews
Screenshot of functionality (including design for comparison)
Screen.Recording.2023-08-18.at.13.23.20.mov