Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hrpsys_ros_bridge_tutorials] fix for min-max table #508

Merged
merged 1 commit into from
May 9, 2017

Conversation

YoheiKakiuchi
Copy link
Member

some robots ignore min-max table by overwriting :init-ending method in -utils.l

@snozawa
Copy link
Collaborator

snozawa commented Apr 18, 2017

お、ホントですね。
既存のメソッドを呼ばずにoverwriteがされてると今後も扱いは面倒になりそうなので、
:init-endingをoverwriteしないようにするのが良さそうですね。

(unless (assoc :init-ending-org (send hrp2jsknt-robot :methods))
  (rplaca (assoc :init-ending (send hrp2jsknt-robot :methods)) :init-ending-org))
(defmethod hrp2jsknt-robot
 (:init-ending (xxx)
  (send self :init-ending-org xxx)
  yyy
  ))

的なかんじにして動いたりするのであれば、これが良さそうです

snozawa added a commit to snozawa/rtmros_tutorials that referenced this pull request Apr 18, 2017
snozawa added a commit to snozawa/rtmros_tutorials that referenced this pull request Apr 18, 2017
…ot define :init-ending if robot-model's :define-min-max-table exists (euslisp/jskeus#428). This will fix the bug (start-jsk#508) because unnecessary :init-ending conflict is resolved.
snozawa added a commit to snozawa/rtmros_tutorials that referenced this pull request Apr 18, 2017
snozawa added a commit to snozawa/rtmros_tutorials that referenced this pull request Apr 19, 2017
@k-okada k-okada self-requested a review May 8, 2017 17:01
Copy link
Member

@k-okada k-okada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

色々議論が出たけどとりあえずこれをマージでいいのでは?

@snozawa
Copy link
Collaborator

snozawa commented May 9, 2017

そうですね、これでいこうと思います。
別途、testコードは別PRに含めてみます。

長期的には、irteusにmin/maxの例をいれるようにできればと考えてます。
ちなみに、そのときにはやはりjointインスタンスの:initのところでなくて、
ロボットクラスの:init-endingがよさそうかと思ってます(make-min/maxするにしても事前生成したものを:define-min/maxするにしても)
理由は、min-maxをつくるのにも、そのjointインスタンスだけでなくて、
前後のjoint, リンクの接合など諸々おわってないといけない、というのに気がついたためです

@snozawa snozawa merged commit 4ec91e3 into start-jsk:master May 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants