Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorder config in CommitmentSchemeProof #1003

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

ohad-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.92%. Comparing base (394f839) to head (93fee9e).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1003   +/-   ##
=======================================
  Coverage   92.92%   92.92%           
=======================================
  Files         105      105           
  Lines       14243    14243           
  Branches    14243    14243           
=======================================
  Hits        13236    13236           
  Misses        927      927           
  Partials       80       80           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 93fee9e Previous: 394f839 Ratio
iffts/simd ifft/20 3066969 ns/iter (± 214773) 1421830 ns/iter (± 83815) 2.16
iffts/simd ifft/21 7936089 ns/iter (± 344821) 3131518 ns/iter (± 173718) 2.53
iffts/simd ifft/22 16566319 ns/iter (± 572867) 6272224 ns/iter (± 205833) 2.64
iffts/simd ifft/23 36444969 ns/iter (± 997101) 14961930 ns/iter (± 137907) 2.44
iffts/simd ifft/24 69109932 ns/iter (± 4148715) 31553077 ns/iter (± 1149565) 2.19
iffts/simd ifft/25 145920743 ns/iter (± 3954754) 64495984 ns/iter (± 1143512) 2.26
iffts/simd ifft/26 293457512 ns/iter (± 12276147) 130127722 ns/iter (± 2059058) 2.26
iffts/simd ifft/27 642241535 ns/iter (± 35126523) 269533636 ns/iter (± 2406787) 2.38
iffts/simd ifft/28 1245044138 ns/iter (± 100511760) 566367730 ns/iter (± 125553309) 2.20
simd rfft 20bit 3360887 ns/iter (± 122634) 1463855 ns/iter (± 15330) 2.30
merkle throughput/simd merkle 36081965 ns/iter (± 970867) 13123349 ns/iter (± 484950) 2.75
simd quotients 2^8 x 2^20 622491035 ns/iter (± 40233008) 270937369 ns/iter (± 2963501) 2.30

This comment was automatically generated by workflow using github-action-benchmark.

CC: @shaharsamocha7

Copy link
Contributor

@andrewmilson andrewmilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @alon-f)

@ohad-starkware ohad-starkware merged commit a194fad into dev Feb 5, 2025
17 of 19 checks passed
@ohad-starkware ohad-starkware deleted the ohad/reorder_proof_struct branch February 5, 2025 07:32
@Alon-Ti Alon-Ti mentioned this pull request Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants