Skip to content

Commit

Permalink
reorder config in CommitmentSchemeProof (#1003)
Browse files Browse the repository at this point in the history
  • Loading branch information
ohad-starkware authored Feb 5, 2025
1 parent 394f839 commit a194fad
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion crates/prover/src/core/pcs/prover.rs
Original file line number Diff line number Diff line change
Expand Up @@ -150,13 +150,13 @@ impl<'a, B: BackendForChannel<MC>, MC: MerkleChannel> CommitmentSchemeProver<'a,

#[derive(Clone, Debug, Serialize, Deserialize)]
pub struct CommitmentSchemeProof<H: MerkleHasher> {
pub config: PcsConfig,
pub commitments: TreeVec<H::Hash>,
pub sampled_values: TreeVec<ColumnVec<Vec<SecureField>>>,
pub decommitments: TreeVec<MerkleDecommitment<H>>,
pub queried_values: TreeVec<Vec<BaseField>>,
pub proof_of_work: u64,
pub fri_proof: FriProof<H>,
pub config: PcsConfig,
}

pub struct TreeBuilder<'a, 'b, B: BackendForChannel<MC>, MC: MerkleChannel> {
Expand Down

1 comment on commit a194fad

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: a194fad Previous: 394f839 Ratio
iffts/simd ifft/21 6391904 ns/iter (± 263122) 3131518 ns/iter (± 173718) 2.04
iffts/simd ifft/22 13347845 ns/iter (± 219803) 6272224 ns/iter (± 205833) 2.13
iffts/simd ifft/26 261860084 ns/iter (± 4208766) 130127722 ns/iter (± 2059058) 2.01
iffts/simd ifft/27 552325305 ns/iter (± 42407901) 269533636 ns/iter (± 2406787) 2.05
merkle throughput/simd merkle 30699984 ns/iter (± 315999) 13123349 ns/iter (± 484950) 2.34

This comment was automatically generated by workflow using github-action-benchmark.

CC: @shaharsamocha7

Please sign in to comment.