Cube252 Component Files #485
Open
+11,925
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Gali-StarkWare
force-pushed
the
gali/cube252_files
branch
from
86341db to
1c5cf09
Compare
This was referenced Feb 9, 2025
Gali-StarkWare
force-pushed
the
gali/cube252_files
branch
from
1c5cf09 to
c1855e0
Compare
Gali-StarkWare
force-pushed
the
gali/packed_felt252packed27
branch
from
04c2ab8 to
52347d6
Compare
Gali-StarkWare
force-pushed
the
gali/cube252_files
branch
from
c1855e0 to
5f00d71
Compare
Gali-StarkWare
force-pushed
the
gali/packed_felt252packed27
branch
from
52347d6 to
e12310e
Compare
Gali-StarkWare
force-pushed
the
gali/cube252_files
branch
from
5f00d71 to
f520f2f
Compare
Gali-StarkWare
commented
Feb 13, 2025
There was a problem hiding this comment.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @ohad-starkware and @shaharsamocha7)
stwo_cairo_prover/crates/prover/src/components/cube_252/prover.rs line 51 at r1 (raw file):
Self { inputs, mults: AtomicMultiplicityColumn::new(1 << log_size),
Anat says that we don't know log_size in advance, so we need to increase mults.len as we add inputs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is