-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PackedFelt252Packed27 #484
base: gali/rc_for_poseidon
Are you sure you want to change the base?
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7)
stwo_cairo_prover/crates/prover_types/src/simd.rs
line 449 at r1 (raw file):
} pub struct PackedFelt252Packed27 {
this name is kind of confusing no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @ohad-starkware and @shaharsamocha7)
stwo_cairo_prover/crates/prover_types/src/simd.rs
line 449 at r1 (raw file):
Previously, ohad-starkware (Ohad) wrote…
this name is kind of confusing no?
I agree, this is how it's auto-generated. We could change the auto-gen code in this case, should we name it PackedFelt252_27? Or something else without the underscore (I don't like it but I wanted to loose the second packed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Gali-StarkWare and @shaharsamocha7)
stwo_cairo_prover/crates/prover_types/src/simd.rs
line 449 at r1 (raw file):
Previously, Gali-StarkWare wrote…
I agree, this is how it's auto-generated. We could change the auto-gen code in this case, should we name it PackedFelt252_27? Or something else without the underscore (I don't like it but I wanted to loose the second packed)
I think the cpu type is the issue, maybe ask DanC if he has ideas to change it?
e312408
to
562aa60
Compare
04c2ab8
to
52347d6
Compare
562aa60
to
72336c7
Compare
52347d6
to
e12310e
Compare
72336c7
to
3fa3272
Compare
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)