Use canonical fully qualified class names for metrics #1680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the current JSON data release does not use the canonical fully-qualified class names; we could use a script to rewrite the JSON to the correct names. |
yifanmai
force-pushed
the
yifanmai/1327-split-metrics
branch
from
e2b5ec9 to
b98ac8b
Compare
teetone
reviewed
Jun 22, 2023
| @@ -1,98 +0,0 @@ | |||
| # Add any classes that need to be loaded dynamically via `create_object`. | |||
teetone
approved these changes
Jun 22, 2023
yifanmai
force-pushed
the
yifanmai/1327-split-metrics
branch
from
6347118 to
89ba7de
Compare
|
mypy is failing due to an unrelated issue |
yifanmai
force-pushed
the
yifanmai/1327-split-metrics
branch
from
89ba7de to
ff3c770
Compare
percyliang
approved these changes
Aug 8, 2023
Comment on lines
+23
to
+25
| class_name = components[-1] | ||
| module_name = ".".join(components[:-1]) | ||
| cls = getattr(importlib.import_module(module_name), class_name) |
There was a problem hiding this comment.
This pattern shows up three times...could we factor it out or put a comment that we need to sync?
Closed
danielz02
pushed a commit
to danielz02/helm
that referenced
this pull request
Sep 7, 2023
danielz02
pushed a commit
to danielz02/helm
that referenced
this pull request
Sep 7, 2023
danielz02
pushed a commit
to danielz02/helm
that referenced
this pull request
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
create_object()is obsolete and incorrect; see this answer for the correct version.This also means we don't need to keep adding names to the
__init__.pyfile.Addresses #1327