-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HEIM #1724
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review only. My main objections:
Blocking:
- Dependency weight - It would be good if we could reduce the required dependency weight further (i.e. remove the google dependencies, which are unneeded for text)
- CI weight - increasing test time by 3x is not acceptable.
- Type checking - there's no type checking to prevent image requests from being sent to text models or vice versa. There's also no type checking to prevent RunSpecs from being composed in nonsensical ways (text metrics on image models) though admittedly this is an existing issue.
- JSON schema extension - The JSON schemas are modified in backward incompatible ways. Additionally, these causes breaks round-trip serialization for certain JSON objects.
- Adapter / request / response extensibility - I would like a proposal that allows extending to model with different type signatures i.e. text / image input, text / image output (or better, N inputs and N outputs, where each of N can be a different type, and there can be multiple input / outputs of the same type). At the bare minimum, this should support CLIP-style models.
Non-blocking:
- This forks the frontend. We want to reconcile it eventually.
- Documentation - there is zero documentation. Additionally, this overrides HELM documentation in undesirable ways (e.g. overriding README)
- This embeds the images as base64 strings, in the JSON, which is maybe not great (I need to think about this more)
@@ -72,6 +72,34 @@ def model_engine(self) -> str: | |||
return model.engine | |||
|
|||
|
|||
@dataclass(frozen=True) | |||
class TextToImageRequest(Request): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This causes Request
to not round-trip to JSON - see the comments under TextToImageAdapterSpec
.
Closing in favor of the fork: https://github.com/stanford-crfm/heim. |
Thanks Tony! More rationale for fork discussed offline, besides the blockers already discussed above:
|
New Scenarios, Models and Metrics for HEIM: https://crfm.stanford.edu/heim/latest/