Chore/port signer v1 tests #4903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacinta Ferrant <[email protected]>
I agree with you-- I think just waiting for the next proposal makes the most sense. |
kantai
reviewed
Jun 25, 2024
obycode
approved these changes
Jun 26, 2024
Merged
Interesting. it passes locally for me as well, but I am wary to merge this as I think this was a flakey test in v1 as well. Gonna look into further to see if I can replicate the CI issue/Aaron's issue. |
github-merge-queue
bot
closed this pull request by merging all changes
into
develop
in
19f753b
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially closes #4802
I only added the mine 2 nakamoto reward cycles test.
The block proposal test was essentially equivalent to miner_gather_signatures test.
The signer reboot test will not work as we do not read stackerdb for missed block proposals on reboot for v0. This does beg the question, should we? Or should signers just wait for a new block proposal from the miners? Should miners try resending their events? I lean toward just waiting and making sure that this timeout rollover works (I believe it is currently broken based on testnet)