Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nakamoto Signer[3.0] - Port v1 signer tests to v0 once end to end miner and signer communication is complete #4802

Closed
jferrant opened this issue May 16, 2024 · 1 comment · Fixed by #4903
Closed

Nakamoto Signer[3.0] - Port v1 signer tests to v0 once end to end miner and signer communication is complete #4802

jferrant opened this issue May 16, 2024 · 1 comment · Fixed by #4903
Assignees
@jferrant
Labels
3.0-Signer 3.0 locked nakamoto
Milestone
Nakamoto-3.0.x

Comments

@jferrant
Copy link
Collaborator

There are some tests (e.g. block_proposal, sign_after_signer_reboot, mine_2_nakamoto_reward_cycles, etc.) that are not v1 specific tests and should be ported to v0 as well. Depends on a working path between miner block proposal, signer response, miner block append in v0.
@github-project-automation github-project-automation bot moved this to Status: 🆕 New in Stacks Core Eng May 16, 2024
@jferrant jferrant moved this from Status: 🆕 New to Status: 📋 Backlog in Stacks Core Eng May 16, 2024
@jferrant jferrant mentioned this issue May 16, 2024
Merged
@jferrant jferrant mentioned this issue May 23, 2024
Merged
@smcclellan smcclellan added the 3.0 label Jun 4, 2024
@saralab saralab removed the 3.0-must label Jun 18, 2024
@jferrant jferrant moved this from Status: 📋 Backlog to Status: 💻 In Progress in Stacks Core Eng Jun 24, 2024
@jferrant jferrant mentioned this issue Jun 24, 2024
Merged
@jferrant jferrant moved this from Status: 💻 In Progress to Status: In Review in Stacks Core Eng Jun 24, 2024
@jferrant jferrant closed this as completed Jul 3, 2024
@github-project-automation github-project-automation bot moved this from Status: In Review to Status: ✅ Done in Stacks Core Eng Jul 3, 2024
@blockstack-devops
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jferrant jferrant

Labels
3.0-Signer 3.0 locked nakamoto
Projects
Stacks Core Eng
Archived in project
Milestone
Nakamoto-3.0.x
Development

Successfully merging a pull request may close this issue.

Chore/port signer v1 tests stacks-network/stacks-core
4 participants
@saralab @smcclellan @jferrant @blockstack-devops