Feat/nakamoto block push #4877
Merged
Feat/nakamoto block push #4877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o keep them separate from new Nakamoto functionality
…/unsolicited.rs), and implement unsolicited NakamotoBlock validation and handling
…blocks. Also, removes tests that are now in net/tests/relay/epoch2x.rs
…ber of buffered messages for each kind of buffered data message we support (including Nakamoto blocks)
…ey can be processed by the relayer
…-- both when we buffer it, and when we relay it
kantai
reviewed
Jun 10, 2024
kantai
previously approved these changes
Jun 12, 2024
obycode
reviewed
Jun 12, 2024
Co-authored-by: Brice Dobry <[email protected]>
obycode
approved these changes
Jun 12, 2024
kantai
approved these changes
Jun 13, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 3, 2024
…or-pr-4877 Add skip header for timeout mutants - pr #4877 related
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #3825 by expanding the relayer logic to both (1) push novel Nakamoto blocks to neighbors, and (2) buffer unsolicited Nakamoto blocks so they can be processed whenever their sortition arrives.
In addition, this PR does some housekeeping by:
src/net/unsolicited.rs)src/net/tests/relay/epoch2x.rs)src/net/relay.rs).Most of the delta in this PR is just housekeeping -- i.e. moving code around and refactoring.
This is a draft for now because I'd like to add some more tests, but the unit tests that are present verify that unsolicited Nakamoto block buffering works, and verify that a follower node can boot up from blocks pushed to it by a seed node.