Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skip header for timeout mutants - pr #4877 related #4918

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

ASuciuX
Copy link
Contributor

@ASuciuX ASuciuX commented Jun 26, 2024

Description

Add mutants skip header for the functions that aren't working with mutation testings.

Applicable issues

@ASuciuX ASuciuX self-assigned this Jun 26, 2024
@ASuciuX ASuciuX linked an issue Jun 26, 2024 that may be closed by this pull request
@ASuciuX ASuciuX requested a review from a team June 26, 2024 21:12
@ASuciuX ASuciuX requested a review from a team as a code owner June 26, 2024 21:17
@wileyj
Copy link
Contributor

wileyj commented Jun 28, 2024

is there a reason they aren't working? is there a case where they may be working with mutants in the future?

@ASuciuX
Copy link
Contributor Author

ASuciuX commented Jun 28, 2024

is there a reason they aren't working? is there a case where they may be working with mutants in the future?

The mutants change the body to a default value and by doing this the http request/response calls are lost. It will always timeout, it the future as well, as it will wait for it but will never happen.

@kantai kantai added this pull request to the merge queue Jul 3, 2024
Merged via the queue into develop with commit 1f5d9d4 Jul 3, 2024
1 check passed
@smcclellan smcclellan deleted the chore/add-skip-mutants-for-pr-4877 branch July 3, 2024 18:55
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Mutations Testing] for PR: Feat/nakamoto block push #4877
4 participants