Remove --platform from start-builder target #1922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Podman has a bug in it which makes it so when using the --platform argument, it will ignore existing images in cache and always attempt to pull. This is particularly annoying when trying to test a change to the builder image, since running the start-builder target will: - Build the image from source. - Pull the image from quay. - Run the image without the local modifications. Removing the argument fixes the issue and it should have no major impact on developer workflow, since it is meant to be used locally anyways.
Stringy
approved these changes
Oct 31, 2024
Stringy
pushed a commit
that referenced
this pull request
Nov 1, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Podman has a bug in it which makes it so when using the --platform argument, it will ignore existing images in cache and always attempt to pull. This is particularly annoying when trying to test a change to the builder image, since running the start-builder target will:
Removing the argument fixes the issue and it should have no major impact on developer workflow, since it is meant to be used locally anyways.
See: containers/podman#24420
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed