Skip to content

Commit

Permalink
Remove --platform from start-builder target (#1922)
Browse files Browse the repository at this point in the history
Podman has a bug in it which makes it so when using the --platform
argument, it will ignore existing images in cache and always attempt to
pull. This is particularly annoying when trying to test a change to the
builder image, since running the start-builder target will:
- Build the image from source.
- Pull the image from quay.
- Run the image without the local modifications.

Removing the argument fixes the issue and it should have no major impact
on developer workflow, since it is meant to be used locally anyways.
  • Loading branch information
Molter73 authored Oct 31, 2024
1 parent 07b5bbb commit 584fd92
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ start-builder: builder teardown-builder
docker run -d \
--name $(COLLECTOR_BUILDER_NAME) \
--pull missing \
--platform ${PLATFORM} \
-v $(CURDIR):$(CURDIR) \
$(if $(LOCAL_SSH_PORT),-p $(LOCAL_SSH_PORT):22 )\
-w $(CURDIR) \
Expand Down

0 comments on commit 584fd92

Please sign in to comment.