Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple empty partitions #156

Merged
merged 4 commits into from
May 12, 2023
Merged

Allow multiple empty partitions #156

merged 4 commits into from
May 12, 2023

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented May 11, 2023

Allows multiple partitions defined in openhpc_slurm_partitions to have no nodes in the appropriate group.

Currently for this case slurm.conf ends up with

NodeName=n/a

for each empty partition, which fails for multiple such partitions:

control slurmctld[102929]: fatal: Duplicated NodeHostName n/a in config file

The fix is to not define that node (NodeName) line for each partition, and generate a partition definition like:

PartitionName=whatever ... Nodes=""

Note this isn't quite as per docs but appears a plausible docs typo - see prior discussion here.

Note a NodeName line is still needed for the case where ALL partitions are empty, which was in the molecule tests.

@sjpb
Copy link
Collaborator Author

sjpb commented May 11, 2023

Hmm, doesn't work as-is for test6 which has NO compute nodes defined at all:

May 11 13:33:13 testohpc-login-0 slurmctld[15082]: error: read_slurm_conf: no nodes configured.
May 11 13:33:13 testohpc-login-0 slurmctld[15082]: fatal: read_slurm_conf reading /etc/slurm/slurm.conf: Invalid argument

@sjpb sjpb marked this pull request as ready for review May 11, 2023 14:14
@sjpb sjpb requested a review from a team as a code owner May 11, 2023 14:14
Copy link
Contributor

@m-bull m-bull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants