Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slurm.conf templating can't handle empty partitions #113

Closed
sjpb opened this issue Aug 11, 2021 · 1 comment
Closed

slurm.conf templating can't handle empty partitions #113

sjpb opened this issue Aug 11, 2021 · 1 comment

Comments

@sjpb
Copy link
Collaborator

sjpb commented Aug 11, 2021

Example of faulty result:

NodeName=DEFAULT State=UNKNOWN \
    RealMemory=122185 \
    Sockets=2 \
    CoresPerSocket=10 \
    ThreadsPerCore=2
NodeName=kbendl-compute-0
NodeName=kbendl-compute-1
PartitionName=baremetal \
    Default=YES \
    MaxTime=86400 \
    State=UP \
    Nodes=\
kbendl-compute-0,\
kbendl-compute-1NodeName=-nonesuch
PartitionName=small \
    Default=YES \
    MaxTime=86400 \
    State=UP \
    Nodes=\
-nonesuch

At a glance I think there's two issues here - empty partitions should probably be ignored (that would be a chance in behaviour, but would be more useful I think), and clearly there's a missing \n here too.

@sjpb
Copy link
Collaborator Author

sjpb commented Sep 8, 2023

Fixed by #156

@sjpb sjpb closed this as completed Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant