Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: export CppAD finder #2112

Merged
merged 4 commits into from
Dec 4, 2023
Merged

CMake: export CppAD finder #2112

merged 4 commits into from
Dec 4, 2023

Conversation

nim65s
Copy link
Contributor

@nim65s nim65s commented Dec 4, 2023

jcarpent
jcarpent previously approved these changes Dec 4, 2023
View reviewed changes
@jcarpent jcarpent enabled auto-merge December 4, 2023 09:25
jcarpent
jcarpent reviewed Dec 4, 2023
View reviewed changes
Copy link
Contributor

@jcarpent jcarpent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved, but in fact you don't have to export CppAD as we do not linked against it for the core project, only for the tests.

@jcarpent jcarpent disabled auto-merge December 4, 2023 10:20
@jcarpent jcarpent enabled auto-merge December 4, 2023 10:26
@jcarpent jcarpent disabled auto-merge December 4, 2023 15:33
@jcarpent jcarpent enabled auto-merge (squash) December 4, 2023 15:34
@jcarpent jcarpent merged commit 9c2e38c into devel Dec 4, 2023
28 checks passed
@jcarpent jcarpent deleted the topic/export-cmake branch December 5, 2023 10:31
nim65s added a commit to nim65s/robotpkg that referenced this pull request Jan 27, 2024
@nim65s
[math/{py-,}pinocchio] Update to v2.7.0
86709d0 
Upstream changes:

    ## [2.7.0] - 2024-01-23

    ### Added
    - Add `GeometryObject::meshMaterial` attribute (stack-of-tasks/pinocchio#2084)

    ### Fixed

    - Use bp::ssize_t for recent version of Windows compilers (stack-of-tasks/pinocchio#2102)
    - Fix missing include for Boost >= 1.83 (stack-of-tasks/pinocchio#2103)
    - Remove f-strings to fix install with python 2 (stack-of-tasks/pinocchio#2110)
    - CMake: stop exporting CppAd/cppadcodegen & fetch submodule if not available (stack-of-tasks/pinocchio#2112)
    - Fix malloc issue in CRBA algo (stack-of-tasks/pinocchio#2126)
    - Fix build cppad and cppadcg with Boost < 1.77 (stack-of-tasks/pinocchio#2132)
@nim65s nim65s mentioned this pull request Jan 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcarpent jcarpent jcarpent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nim65s @jcarpent