Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove joda time #153

Merged
merged 2 commits into from
Sep 29, 2020
Merged

Remove joda time #153

merged 2 commits into from
Sep 29, 2020

Conversation

jisantuc
Copy link
Contributor

@jisantuc jisantuc commented Sep 29, 2020

Overview

This PR removes joda time, since @pomadchin worked the DateTimeFormat magic for us to get by without requiring the dep (and even added more format unit tests).

Checklist

  • New tests have been added or existing tests have been modified
  • Changelog updated

Addresses #150
Replaces #152

@jisantuc
Copy link
Contributor Author

I can't approve because I opened it but @pomadchin feel free to merge with a changelog entry

@pomadchin
Copy link
Collaborator

For the context (if there would be any questions about the joda-time dep in general and why it disappeared from modern libs): https://github.com/JodaOrg/joda-time#joda-time

Joda-time is no longer in active development except to keep timezone data up to date. From Java SE 8 onwards, users are asked to migrate to java.time (JSR-310) - a core part of the JDK which replaces this project. For Android users, java.time is added in API 26+. Projects needing to support lower API levels can use the ThreeTenABP library.

It is mostly not recommended to have joda-time in deps of a new project.

@pomadchin
Copy link
Collaborator

pomadchin commented Sep 29, 2020

According to STAC Docs, it follows RFC3339, that is why we need an RFC3339 compatible ISO Formatter. Such formatter description is described in this SO post.

Also a nice post that explains ISO formatter implementation in Java

@pomadchin pomadchin merged commit 2d2b64c into stac-utils:master Sep 29, 2020
@pomadchin pomadchin deleted the feautre/java-time branch September 29, 2020 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants