Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from java.time.Instant to org.joda.time.Instant #152

Merged
merged 6 commits into from
Sep 29, 2020

Conversation

jisantuc
Copy link
Contributor

@jisantuc jisantuc commented Sep 28, 2020

Overview

joda.time.Instant.parse successfully parses a much wider range of valid ISO8601 timestamp formats (including +00 and -00 for time zone indications -- what even produces those? Clocks were a mistake).

Checklist

  • New tests have been added or existing tests have been modified
  • Changelog updated

Notes

The seemingly too specific decoder is the way it is because of the consistency law -- with emapTry, the exceptions weren't evaluating as equal, so the test kept failing.

Closes #150

Copy link

@notthatbreezy notthatbreezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. One suggestion though, add some tests that cover a few examples of formats that stac4s can now parse, but previously could not.

@jisantuc jisantuc merged commit 8c745a4 into master Sep 29, 2020
@jisantuc jisantuc deleted the feature/js/use-zoneddatetime-instead-of-instant branch September 29, 2020 15:20
@pomadchin pomadchin mentioned this pull request Sep 29, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time parsing too strict
2 participants