Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use stac-api-validator in ci #508

Merged
merged 8 commits into from
Jan 18, 2023
Merged

Use stac-api-validator in ci #508

merged 8 commits into from
Jan 18, 2023

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Dec 29, 2022 •
edited
Loading

Description:

It'd be nice to validate our API as a part of CI. This PR adds support via stac-api-validator.

IMO these validation checks should be added to the required check list once this PR is passing CI.

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Add new checks to the required checks list

Sidecar fixes

@gadomski gadomski force-pushed the validate-in-ci branch 8 times, most recently from 126069a to ac8779a Compare December 30, 2022 14:15
@gadomski gadomski mentioned this pull request Dec 30, 2022
Closed
@gadomski gadomski self-assigned this Dec 30, 2022
@gadomski gadomski added the enhancement New feature or request label Dec 30, 2022
@gadomski gadomski marked this pull request as ready for review January 10, 2023 18:21
@gadomski gadomski marked this pull request as draft January 10, 2023 18:24
@gadomski gadomski force-pushed the validate-in-ci branch 8 times, most recently from 3d7f00d to c46fdc0 Compare January 13, 2023 15:51
@gadomski gadomski marked this pull request as ready for review January 13, 2023 15:58
@gadomski gadomski requested a review from philvarner January 13, 2023 15:58
@gadomski
fix: exclude optional collection values
3bff044 
If we're not using response models, we can't automagically exclude none values.
@gadomski
fix: add required links to item collection
b69c221 
sqlalchemy
vincentsarago
vincentsarago approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@vincentsarago vincentsarago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@gadomski gadomski merged commit 15b21b0 into master Jan 18, 2023
@gadomski gadomski deleted the validate-in-ci branch January 18, 2023 11:51
gadomski added a commit that referenced this pull request Jan 18, 2023
@gadomski
chore: update changelog for #508
5c43785
@gadomski gadomski mentioned this pull request Jan 18, 2023
Merged
3 tasks
@gadomski gadomski added this to the 2.4.4 milestone Jan 18, 2023
gadomski added a commit that referenced this pull request Jan 18, 2023
@gadomski
chore: update changelog for #508 (#512)
3db04da
@gadomski gadomski mentioned this pull request Feb 14, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentsarago vincentsarago vincentsarago approved these changes

@philvarner philvarner Awaiting requested review from philvarner

Assignees

@gadomski gadomski

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.4.4
3 participants
@gadomski @philvarner @vincentsarago