Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-zero exit code for validation errors #209

Closed
gadomski opened this issue Dec 30, 2022 · 0 comments · Fixed by #217
Closed

Non-zero exit code for validation errors #209

gadomski opened this issue Dec 30, 2022 · 0 comments · Fixed by #217
Assignees
@gadomski
Labels
enhancement New feature or request

Comments

@gadomski
Copy link
Member

I'd like to use stac-api-validator in a CI/CD pipeline: stac-utils/stac-fastapi#508. Currently, stac-api-validator is returning a 0 exit code even if there's a jsonschema validation error (out-of-the-box stac-fastapi-pgstac produces invalid STAC ATM):

Screen Shot 2022-12-30 at 7 17 26 AM

It would be nice to return a non-zero code that would cause my Github workflow to fail.
@gadomski gadomski added the enhancement New feature or request label Dec 30, 2022
@philvarner philvarner added this to the v0.5.0 milestone Jan 3, 2023
@gadomski gadomski self-assigned this Jan 10, 2023
@gadomski gadomski mentioned this issue Jan 10, 2023
Merged
philvarner added a commit that referenced this issue Jan 10, 2023
@philvarner
Merge pull request #217 from /issues/209-non-zero-exit-code
2649739 
sys.exit with return code
@philvarner philvarner removed this from the v0.9.0 milestone Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gadomski gadomski

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sys.exit with return code stac-utils/stac-api-validator
2 participants
@gadomski @philvarner