Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove fastapi dep to solve #47 #54

Merged
merged 5 commits into from
May 3, 2024
Merged

remove fastapi dep to solve #47 #54

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fb403ef
remove fastapi dep
May 1, 2024
413bfa0
remove uvicorn from prd.txt
May 1, 2024
ffa2e50
resolve conflict of prd.txt
May 1, 2024
076bd6a
resolve 2 conflict of prd.txt
May 1, 2024
28dc8c8
update prd.txt to latest
May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion requirements/prd.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,4 @@ ray[default]==2.9.3
rdkit_pypi==2022.9.5
torch==2.2.0
torch_geometric==2.5.2
fastapi==0.110.0
uvicorn[standard]==0.29.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you still need this or can it get nuked also?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FastAPI can be removed as it is not in use in Bluephos project.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, the above inline comment was on line 8 in reference to uvicorn, which is probably only needed for fastapi. If this is true, it should get removed in this PR also, no?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I've also removed Unicorn after checking, and I've updated the PR accordingly.
Thanks!

Loading