-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove fastapi dep to solve #47 #54
Conversation
requirements/prd.txt
Outdated
@@ -5,5 +5,4 @@ ray[default]==2.9.3 | |||
rdkit_pypi==2022.9.5 | |||
torch==2.2.0 | |||
torch_geometric==2.5.2 | |||
fastapi==0.110.0 | |||
uvicorn[standard]==0.29.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you still need this or can it get nuked also?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FastAPI can be removed as it is not in use in Bluephos project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, the above inline comment was on line 8 in reference to uvicorn
, which is probably only needed for fastapi
. If this is true, it should get removed in this PR also, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I've also removed Unicorn after checking, and I've updated the PR accordingly.
Thanks!
@xiangchenjhu I see that there's an extra three commits to update with main and resolve conflicts, FYI, these shouldn't have been necessary. A good practice for updating your branch with main is to do the following (with conflicts in requirements/prd.txt):
If not familiar with rebasing, I always advise creating a backup of your branch first using (assuming already on branch)
|
Thank you @jamienoss . I just noticed this helpful suggestion. It should be handy for future use. |
remove unnecessary dependent
resolves #47