rename shell (ansible#806)

Rename `shell` to `use_shell` in one unit test Given the possibility of some future static analysis tool misinterpreting shell=True as a subprocess parameter/call, it was changed here to read use_shell. This also eliminates the 2 false positives being reported by flake8-bandit which is part of the wemake style guide being vetted. tests/unit/actions/test_exec.py:34:1: S604 Function call with shell=True parameter identified, possible security issue. shell=True, ^ tests/unit/actions/test_exec.py:49:1: S604 Function call with shell=True parameter identified, possible security issue. shell=True, ^ Reviewed-by: Sviatoslav Sydorenko <webknjaz+github/[email protected]> Reviewed-by: None <None>
ssbarnea · Jan 30, 2022 · 72c5470 · 72c5470
1 parent c1f78fc
commit 72c5470
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/tests/unit/actions/test_exec.py b/tests/unit/actions/test_exec.py
@@ -13,7 +13,7 @@ class CommandTestData(NamedTuple):
 
     name: str
     command: str
-    shell: bool
+    use_shell: bool
     result_command: str
     result_params: List
 
@@ -31,22 +31,22 @@ def id_from_data(test_value):
     CommandTestData(
         name="With shell simple",
         command="echo foo",
-        shell=True,
+        use_shell=True,
         result_command="/bin/bash",
         result_params=["-c", "echo foo"],
     ),
     CommandTestData(
         name="Without shell simple",
         command="echo foo",
-        shell=False,
+        use_shell=False,
         result_command="echo",
         result_params=["foo"],
     ),
     CommandTestData(
         name="With shell complex",
         command="ansible-vault encrypt_string --vault-password-file"
         + " a_password_file 'foobar' --name 'the_secret'",
-        shell=True,
+        use_shell=True,
         result_command="/bin/bash",
         result_params=[
             "-c",
@@ -58,7 +58,7 @@ def id_from_data(test_value):
         name="Without shell complex",
         command="ansible-vault encrypt_string --vault-password-file"
         + " a_password_file 'foobar' --name 'the secret'",
-        shell=False,
+        use_shell=False,
         result_command="ansible-vault",
         result_params=[
             "encrypt_string",
@@ -80,7 +80,7 @@ def test_artifact_path(cmd_test_data: CommandTestData):
     """
     command, additional_params = _generate_command(
         exec_command=cmd_test_data.command,
-        exec_shell=cmd_test_data.shell,
+        exec_shell=cmd_test_data.use_shell,
     )
     comment = command_test_data, command, additional_params
     assert command == cmd_test_data.result_command, comment