Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Disable 2 `flake8-bandit` checks (S404 and S603) in one unit test These are reported by flake8-bandit which is part of the wemake-python style guide being vetted Noting how and why subprocess was used seems reasonable here for future reviews that might see it. tests/unit/test_circular_imports.py:14:1: S404 Consider possible security implications associated with the subprocess module. import subprocess ^ tests/unit/test_circular_imports.py:104:1: S603 subprocess call - check for execution of untrusted input. subprocess.check_call(imp_cmd) ^ Details can be found here: https://bandit.readthedocs.io/en/latest/blacklists/blacklist_imports.html?highlight=B404 and here: https://bandit.readthedocs.io/en/latest/plugins/index.html#complete-test-plugin-listing Note- The flake8-bandit extension changes the B to an S see https://github.com/tylerwince/flake8-bandit Reviewed-by: Sviatoslav Sydorenko <webknjaz+github/[email protected]> Reviewed-by: None <None>
- Loading branch information