Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse RenderContext; unfreeze before rendering #850

Merged
merged 1 commit into from
Jul 29, 2022
Merged

Reuse RenderContext; unfreeze before rendering #850

merged 1 commit into from
Jul 29, 2022

Conversation

steve-the-edwards
Copy link
Contributor

@steve-the-edwards steve-the-edwards commented Jul 29, 2022 •
edited
Loading

Addresses #849

@steve-the-edwards steve-the-edwards marked this pull request as ready for review July 29, 2022 19:20
@steve-the-edwards
Copy link
Contributor Author

The frame timeout tests are failing consistently. Which means there is somethign to investigate with re-using the RenderContext when we use the FrameTimeout optimization. This isn't used anywhere though yet that we know of. I would suggest we go ahead with merging this and I will turn off those tests for now.

@rjrjr @RBusarow WDYT?

@steve-the-edwards
Reuse RenderContext; unfreeze before rendering
42537ce 
Turn off the FrameTimeout instrumentation tests which were consistently failing.

We will have to fix these before considering #849 solved.
@steve-the-edwards steve-the-edwards force-pushed the sedwards/reuse-actionSink branch from 2094abd to 42537ce Compare July 29, 2022 21:01
@RBusarow
Copy link
Collaborator

The frame timeout tests are failing consistently. Which means there is somethign to investigate with re-using the RenderContext when we use the FrameTimeout optimization. This isn't used anywhere though yet that we know of. I would suggest we go ahead with merging this and I will turn off those tests for now.

@rjrjr @RBusarow WDYT?

Seems reasonable to me.

@steve-the-edwards steve-the-edwards merged commit c4278a6 into main Jul 29, 2022
@steve-the-edwards steve-the-edwards deleted the sedwards/reuse-actionSink branch July 29, 2022 21:51
@rjrjr
Copy link
Contributor

rjrjr commented Jul 29, 2022

+1, let's fix the real world problem ASAP.

@steve-the-edwards steve-the-edwards mentioned this pull request Aug 3, 2022
Closed
@steve-the-edwards steve-the-edwards mentioned this pull request Apr 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjrjr rjrjr rjrjr approved these changes

@zach-klippenstein zach-klippenstein Awaiting requested review from zach-klippenstein zach-klippenstein is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@steve-the-edwards @RBusarow @rjrjr