Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid recreating RenderContext so that the actionSink captured in lambdas can be memoized #849

Closed
steve-the-edwards opened this issue Jul 29, 2022 · 2 comments
Closed

Avoid recreating RenderContext so that the actionSink captured in lambdas can be memoized #849

steve-the-edwards opened this issue Jul 29, 2022 · 2 comments
Labels
compose enhancement New feature or request optimization Issues related to benchmarking and optimization

Comments

@steve-the-edwards
Copy link
Contributor

Right now the Recomposer sees a different object each time and will force recomposition.
@steve-the-edwards steve-the-edwards added enhancement New feature or request compose optimization Issues related to benchmarking and optimization labels Jul 29, 2022
@rjrjr
Copy link
Contributor

rjrjr commented Jul 29, 2022

Seems like we could still have them pass out the same / equal object from actionSink instead of this, rather than avoid the recreation entirely. Could be simpler.

@steve-the-edwards steve-the-edwards mentioned this issue Jul 29, 2022
Merged
steve-the-edwards added a commit that referenced this issue Jul 29, 2022
@steve-the-edwards
Reuse RenderContext; unfreeze before rendering
42537ce 
Turn off the FrameTimeout instrumentation tests which were consistently failing.

We will have to fix these before considering #849 solved.
@steve-the-edwards
Copy link
Contributor Author

Fixed by #850

@steve-the-edwards steve-the-edwards mentioned this issue Apr 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compose enhancement New feature or request optimization Issues related to benchmarking and optimization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rjrjr @steve-the-edwards