Heap dumps on SD card #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Heap dumps and analysis results were previously saved in the app directory. They are now saved on the external storage (sd card). * Centralized internal static helper methods to a dedicated class: `LeakCanaryInternals`. BREAKING CHANGES * When upgrading, previously saved heap dumps will be lost, but won't be removed from the app directory. You should probably uninstall your app. * Added permission WRITE_EXTERNAL_STORAGE * Public API change: Removed `Application` parameter in `LeakCanary.androidWatcher()` * Public API change: Removed `Application` parameter in `AndroidHeapDumper()` * Fixes #21 (can't share heap dump) * This is a step towards fixing #15 (strict mode violations), although there's still more work.
|
cc @swankjesse |
pyricau
added a commit
that referenced
this pull request
May 10, 2015
TMP COMMIT, DO NOT MERGE. This enables Strict Mode. Once #27 is merged, we can move forwards fixing all strict mode violations.
pyricau
added a commit
that referenced
this pull request
May 10, 2015
TMP COMMIT, DO NOT MERGE. This enables Strict Mode in the sample app. Once #27 is merged, we can move forwards fixing all strict mode violations.
|
Dig. |
Yky
pushed a commit
to Yky/leakcanary
that referenced
this pull request
Feb 21, 2016
Heap dumps on SD card
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LeakCanaryInternals.BREAKING CHANGES
Applicationparameter inLeakCanary.androidWatcher()Applicationparameter inAndroidHeapDumper()