Leak in MediaScannerConnection

[fasteque]

In com.fastebro.androidrgbtool:1.5.0:10.
* com.fastebro.androidrgbtool.ui.MainActivity has leaked:
* GC ROOT android.media.MediaScannerConnection$1.this$0 (anonymous class extends android.media.IMediaScannerListener$Stub)
* references android.media.MediaScannerConnection.mContext
* leaks com.fastebro.androidrgbtool.ui.MainActivity instance

* Reference Key: b9ba263e-f5ce-4117-bfa5-23f921e13052
* Device: motorola google Nexus 6 shamu
* Android Version: 5.1 API: 22
* Durations: watch=5048ms, gc=153ms, heap dump=1707ms, analysis=15593ms

My code simply call the scanFile like the ExternalStorage official APIs demo.
Found it while testing my app but I'm not able to reproduce it systematically.

[pyricau]

Dang. That's another binder leak.

Can you give me a link to the ExternalStorage official APIs demo sources?

[fasteque]

Thanks, here you can find the demo sources: https://android.googlesource.com/platform/development/+/master/samples/ApiDemos/src/com/example/android/apis/content/ExternalStorage.java

[pyricau]

When passing an activity context, the service should automatically unbind when the activity is destroyed. MediaScannerConnection#mService should have been null.

Could you provide a link to the heap dump so that I have a look?

[fasteque]

I'd like to do that but it looks like I can't share with any app (Inbox, GMail, beam transfer, upload on Google Drive, ...): is it stored in the private app space?

[pyricau]

Yes. This will be fixed in #27 . In the meantime, you can use adb shell "run-as com.your.packagename cp <source> <dest>" to copy to sd card and then access it.

[fasteque]

Yep, I tried earlier to run that command, always getting "permission-denied" error or "read-only file system"... maybe because my device is encrypted?
Anyway, I finally managed to get the content of my app folder with an adb backup without encryption, so please find here below the links:
https://dl.dropboxusercontent.com/u/91338451/heap_dump_0.hprof
https://dl.dropboxusercontent.com/u/91338451/heap_dump_0.hprof.result

Let me know if you have any trouble getting the files.

Thanks!

[andhie]

@fasteque if cp didnt work, try with cat. i have tested it to be working
adb shell "run-as com.your.packagename cat /data/data/com.your.packagename/files/detected_leaks/heap_dump_0.hprof.result > /sdcard/dump_0.hprof"

[pyricau]

Filed here: https://code.google.com/p/android/issues/detail?id=173788

[southsea]

It seems never call onServiceDisconnected method on MediaScannerConnection class when App exits.
That can't release mService and mClient, then leak occured.