Remove implicitly-included java.base dep in module-info #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like
java.base
is an implicit requirement and explicitly requiring it raises an error here.I've confirmed that removing the
requires
allows a minimal test project to compile and run.The place I encountered this was using
maven-compiler-plugin
3.8.0 in thecompile
goal:I'd like to believe that this was a recent change or due to some unfortunate combination of plugin/jvm/target versions but AFAICT this happens with Java 9+ with target of Java 9+ so I'd need to apologize for the bad PR before. I'm not sure why I added it originally.