You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@UkonnRa First of all, thank you for reporting it. While it's unfortunate no one spotted this with 2.12.0-rc2 we at least have a chance to improve this for 2.12.1.
Bust just to make: it sounds like we so should just remove requires java.base? That does not seem to be included in any other module-info.java declarations (for Jackson modules) so seems unnecessary (plus since it's the core piece of JDK it should always be there anyway). It seems odd to me that this should cause problems (while redundant, why would this cause failure?) but I don't really know or use JPMS at this point so perhaps there is a good reason; or maybe it's an oddity of some specific piece of tooling. Either way if it is not needed but causes problems we should remove it.
cowtowncoder
changed the title
Remove implicitly-included java.base dep in module-info
Remove implicitly-included java.base dep in module-info.javaDec 31, 2020
Removed unnecessary java.base and also fixed incorrect reference (was com.fasterxml.jackson.annotations, should be com.fasterxml.jackson.annotation (no trailing "s")). Will push 2.12.1-SNAPSHOT if anyone could test and verify that things now work better.
Describe the bug
Same as this issue, java.base is implicitly-included so you cannot add it again, or exception will be thrown
To Reproduce
Use jackson-kotlin with Java module, you will see this error
Expected behavior
Everything should work fine
Versions
Kotlin: 1.4.30-M1
Jackson-module-kotlin: 2.12.0
Jackson-databind: 2.12.0
The text was updated successfully, but these errors were encountered: