Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme - improve a few icons #472

Closed
vogella opened this issue Jun 2, 2020 · 4 comments
Closed

Dark theme - improve a few icons #472

vogella opened this issue Jun 2, 2020 · 4 comments
Milestone

Comments

@vogella
Copy link

vogella commented Jun 2, 2020

Dark theme look great in STS4 with Eclipse 4.16. I just noticed three icons which still have white dots around them, see screenshot.

icons-sts

@kdvolder
Copy link
Member

kdvolder commented Jun 2, 2020

The icon in the bottom right... I don't think that is one of ours. I think it's the icon for the Ansi console plugin: https://github.com/mihnita/ansi-econsole

@vogella
Copy link
Author

vogella commented Jun 2, 2020

Reported mihnita/ansi-econsole#52

@kdvolder
Copy link
Member

kdvolder commented Sep 9, 2020

I'll try and fix the restart icon it does look a bit off.

For the light-bulb... I actually think we should just leave it as is (feel free to argue with me however :-). But, I mean... it is a light bulb... so it is kind of natural to have some 'glow' around it. If I remove these 'glow pixels' the next pixels around is the black line around the yellow area of the bulb. And those will be completely invisible in dark theme. So I think it would actually look worse.

@vogella
Copy link
Author

vogella commented Sep 9, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants