-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark theme - improve a few icons #472
Comments
The icon in the bottom right... I don't think that is one of ours. I think it's the icon for the Ansi console plugin: https://github.com/mihnita/ansi-econsole |
Reported mihnita/ansi-econsole#52 |
I'll try and fix the restart icon it does look a bit off. For the light-bulb... I actually think we should just leave it as is (feel free to argue with me however :-). But, I mean... it is a light bulb... so it is kind of natural to have some 'glow' around it. If I remove these 'glow pixels' the next pixels around is the black line around the yellow area of the bulb. And those will be completely invisible in dark theme. So I think it would actually look worse. |
Sounds good. Thanks
Kris De Volder <[email protected]> schrieb am Mi., 9. Sept. 2020,
20:27:
… I'll try and fix the restart icon it does look a bit off.
For the light-bulb... I actually think we should just leave it as is (feel
free to argue with me however :-). But, I mean... it is a light bulb... so
it is kind of natural to have some 'glow' around it. If I remove these
'glow pixels' the next pixels around is the black line around the yellow
area of the bulb. And those will be completely invisible in dark theme. So
I think it would actually look worse.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#472 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABCFBUVYRM63TAP6KZBQJTSE7CHXANCNFSM4NQSV2TQ>
.
|
Dark theme look great in STS4 with Eclipse 4.16. I just noticed three icons which still have white dots around them, see screenshot.
The text was updated successfully, but these errors were encountered: