Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix icon background (white dots) #52

Closed
vogella opened this issue Jun 2, 2020 · 2 comments
Closed

Fix icon background (white dots) #52

vogella opened this issue Jun 2, 2020 · 2 comments
Assignees
Labels
Milestone

Comments

@vogella
Copy link

vogella commented Jun 2, 2020

Reported to STS but it seems to belong here:

spring-projects/sts4#472 (comment)

@mihnita
Copy link
Owner

mihnita commented Jun 6, 2020

Thanks.

I already knew what the problem (long ago), but didn't have a fix.
When I started this plugin I thought that the only possible formats for icons were .gif and .jpg, and .gif was the only one with transparency. But there is only 1 bit of transparency, meaning "jagged" edges. And was also at the time when Eclipse didn't have a dark mode, so it was ok.

But times changes :-)
I can replace the icons with .png, but...

There is a bigger change that I have in the pipeline, fixing (among others) issue #45.
It uses the standard Eclipse mechanism for enabled/disabled icons (right now I use 2 icons of my own, and change them). Eclipse takes the enabled icon and "disables" it algorithmically, using some kind of overlay.
The difference between states is not as visible as it is now, and I don't like it, but it is standard Eclipse, instead of my own hack.

@mihnita mihnita self-assigned this Jul 10, 2020
@mihnita mihnita added the bug label Jul 10, 2020
@mihnita mihnita added this to the 1.4.4 milestone Feb 5, 2021
@mihnita
Copy link
Owner

mihnita commented Feb 8, 2021

Fixed and released.

@mihnita mihnita closed this as completed Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants