Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove logic to handle "magic" client-side indentation #1154

Closed
martinlippert opened this issue Dec 1, 2023 · 1 comment
Closed

remove logic to handle "magic" client-side indentation #1154

martinlippert opened this issue Dec 1, 2023 · 1 comment
Assignees
@martinlippert
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: code completion type: enhancement
Milestone
4.22.1.RELEASE

Comments

@martinlippert
Copy link
Member

As part of #1153, we already disabled the workarounds for specific client-side magic indentation, since we configure completion items now with a InsertTextModeof As-Is, which causes the client to not apply its own logic to add indentation.

This issue here is to cleanup the unused code and logic around this, specially inside VscodeCompletionEngineAdapter
@martinlippert martinlippert added type: enhancement for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: code completion labels Dec 1, 2023
@martinlippert martinlippert added this to the 4.21.1.RELEASE milestone Dec 1, 2023
@martinlippert martinlippert self-assigned this Dec 1, 2023
@martinlippert martinlippert mentioned this issue Dec 1, 2023
Closed
martinlippert added a commit that referenced this issue Apr 23, 2024
@martinlippert
GH-1154: removed logic to handle client-side magic indentation, no lo…
029cc73 
…nger necessary as completions are marked as-is for indentation
@martinlippert
Copy link
Member Author

Done, cleanup work finished with 029cc73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martinlippert martinlippert

Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: code completion type: enhancement
Projects
None yet
Milestone
4.22.1.RELEASE
Development

No branches or pull requests
2 participants
@martinlippert @BoykoAlex