Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indentation is broken for @GetMapping snippet completion #1153

Closed
martinlippert opened this issue Dec 1, 2023 · 1 comment
Closed

indentation is broken for @GetMapping snippet completion #1153

martinlippert opened this issue Dec 1, 2023 · 1 comment
Assignees
Labels
for: vscode something that is specific for VSCode theme: code completion type: bug

Comments

@martinlippert
Copy link
Member

the indentation is broken when inserting a @GetMapping snippet completion. Results look like this:

	<*>@GetMapping("path")
public SomeData getMethodName(@RequestParam String param) {
	return new SomeData();
}

(where the <*> marks the position of the cursor when invoking the code completion)

@martinlippert
Copy link
Member Author

Fixed with ae68b8e. Due to the new InsertTextMode that we set to As-Is, we don't need to deal with magic client-side indentation anymore and need to remove that logic.

Additional code cleanup work is needed for the next cycle: #1154

martinlippert added a commit that referenced this issue Dec 1, 2023
…eed to deal with client-side magic indentation anymore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: vscode something that is specific for VSCode theme: code completion type: bug
Projects
None yet
Development

No branches or pull requests

1 participant