Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nested suspend calls for Kotlin coroutines #13766

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

sjohnr
Copy link
Member

@sjohnr sjohnr commented Aug 31, 2023

This draft PR updates PrePostAdviceReactiveMethodInterceptor to utilize Framework's new support for Kotlin coroutines, along with fixing tests that began failing after this change.

Closes gh-13764

cc @jzheaux @sdeleuze

@sjohnr sjohnr self-assigned this Aug 31, 2023
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, @sjohnr, thanks for working on this. I've left my feedback inline.

@sjohnr sjohnr marked this pull request as ready for review September 5, 2023 05:22
@sjohnr sjohnr merged commit 92256f0 into spring-projects:main Sep 5, 2023
@sjohnr sjohnr deleted the gh-13764 branch September 5, 2023 05:23
@sjohnr sjohnr added this to the 6.2.0-M3 milestone Sep 5, 2023
@sjohnr sjohnr added in: core An issue in spring-security-core type: enhancement A general enhancement labels Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core An issue in spring-security-core type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support nested suspend calls for Kotlin coroutines
3 participants