Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support nested suspend calls for Kotlin coroutines #13764

Closed
sjohnr opened this issue Aug 31, 2023 · 0 comments · Fixed by #13766
Closed

Support nested suspend calls for Kotlin coroutines #13764

sjohnr opened this issue Aug 31, 2023 · 0 comments · Fixed by #13766
Assignees
@sjohnr
Labels
in: core An issue in spring-security-core status: duplicate A duplicate of another issue type: enhancement A general enhancement

Comments

@sjohnr
Copy link
Member

sjohnr commented Aug 31, 2023

PrePostAdviceReactiveMethodInterceptor does not currently support nested suspend calls for Kotlin coroutines.

We should use the new built-in support for Kotlin coroutines available with spring-projects/spring-framework#22462 (currently available in Spring Framework 6.1.0-SNAPSHOT).
@sjohnr sjohnr added in: core An issue in spring-security-core type: enhancement A general enhancement labels Aug 31, 2023
@sjohnr sjohnr self-assigned this Aug 31, 2023
@sjohnr sjohnr changed the title Use built-in support for Kotlin coroutines Support nested suspend calls for Kotlin coroutines Aug 31, 2023
@sjohnr sjohnr mentioned this issue Aug 31, 2023
Closed
@sjohnr sjohnr mentioned this issue Aug 31, 2023
Merged
@sjohnr sjohnr moved this to In Progress in Spring Security Team Sep 1, 2023
@sjohnr sjohnr mentioned this issue Sep 1, 2023
Closed
sjohnr added a commit to sjohnr/spring-security that referenced this issue Sep 1, 2023
@sjohnr
Support nested suspend calls for Kotlin coroutines
bb52cdf 
Closes spring-projectsgh-13764
sjohnr added a commit that referenced this issue Sep 5, 2023
@sjohnr
Support nested suspend calls for Kotlin coroutines
92256f0 
Closes gh-13764
@sjohnr sjohnr added the status: duplicate A duplicate of another issue label Sep 5, 2023
@sjohnr sjohnr moved this from In Progress to Done in Spring Security Team Sep 5, 2023
@sjohnr sjohnr mentioned this issue Sep 7, 2023
Open
7 tasks
@sjohnr sjohnr mentioned this issue Nov 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjohnr sjohnr

Labels
in: core An issue in spring-security-core status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
Spring Security Team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support nested suspend calls for Kotlin coroutines sjohnr/spring-security
1 participant
@sjohnr