Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ID to Saml2 Post and Redirect Requests #11489

Merged
merged 2 commits into from
Aug 2, 2022
Merged

Add ID to Saml2 Post and Redirect Requests #11489

merged 2 commits into from
Aug 2, 2022

Conversation

scottshidlovsky
Copy link
Contributor

Closes gh-11468

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 12, 2022
@scottshidlovsky scottshidlovsky marked this pull request as ready for review July 12, 2022 15:13
@sjohnr sjohnr added status: duplicate A duplicate of another issue type: enhancement A general enhancement in: saml2 An issue in SAML2 modules and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 13, 2022
jzheaux
jzheaux requested changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @scottshidlovsky! I've left some feedback inline.

...ework/security/saml2/provider/service/authentication/AbstractSaml2AuthenticationRequest.java Outdated Show resolved Hide resolved
...ework/security/saml2/provider/service/authentication/AbstractSaml2AuthenticationRequest.java Show resolved Hide resolved
...ework/security/saml2/provider/service/authentication/AbstractSaml2AuthenticationRequest.java Show resolved Hide resolved
...va/org/springframework/security/saml2/jackson2/Saml2PostAuthenticationRequestMixinTests.java Show resolved Hide resolved
...ty/saml2/provider/service/web/authentication/OpenSamlAuthenticationRequestResolverTests.java Outdated Show resolved Hide resolved
@jzheaux jzheaux added this to the 5.8.0-M2 milestone Jul 18, 2022
@scottshidlovsky
Copy link
Contributor Author

Thanks, @scottshidlovsky! I've left some feedback inline.

Thank you for the review! I believe I have addressed all your feedback.

@scottshidlovsky scottshidlovsky requested a review from jzheaux July 23, 2022 19:14
@jzheaux jzheaux merged commit 508f7d7 into spring-projects:main Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees

@jzheaux jzheaux

Labels
in: saml2 An issue in SAML2 modules status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
5.8.0-M2
Development

Successfully merging this pull request may close these issues.

Receive AuthnRequest Id and Response InResponseTo in Saml2AuthenticationRequestRepository
4 participants
@scottshidlovsky @jzheaux @sjohnr @spring-projects-issues