Update OpenSamlAuthenticationRequestResolverTests from Junit 4 to Jun…

…it 5
spring-projects · Jul 23, 2022 · 2ff2467 · 2ff2467
1 parent 5f0c150
commit 2ff2467
Showing 1 changed file with 13 additions and 5 deletions.
diff --git a/...saml2/provider/service/web/authentication/OpenSamlAuthenticationRequestResolverTests.java b/...saml2/provider/service/web/authentication/OpenSamlAuthenticationRequestResolverTests.java
@@ -16,8 +16,8 @@
 
 package org.springframework.security.saml2.provider.service.web.authentication;
 
-import org.junit.Before;
-import org.junit.Test;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
 import org.opensaml.xmlsec.signature.support.SignatureConstants;
 
 import org.springframework.mock.web.MockHttpServletRequest;
@@ -40,7 +40,7 @@ public class OpenSamlAuthenticationRequestResolverTests {
 
 	private RelyingPartyRegistration.Builder relyingPartyRegistrationBuilder;
 
-	@Before
+	@BeforeEach
 	public void setUp() {
 		this.relyingPartyRegistrationBuilder = TestRelyingPartyRegistrations.relyingPartyRegistration();
 	}
@@ -65,6 +65,7 @@ public void resolveAuthenticationRequestWhenSignedRedirectThenSignsAndRedirects(
 		assertThat(result.getSigAlg()).isEqualTo(SignatureConstants.ALGO_ID_SIGNATURE_RSA_SHA256);
 		assertThat(result.getSignature()).isNotEmpty();
 		assertThat(result.getBinding()).isEqualTo(Saml2MessageBinding.REDIRECT);
+		assertThat(result.getId()).isNotEmpty();
 	}
 
 	@Test
@@ -88,6 +89,7 @@ public void resolveAuthenticationRequestWhenUnsignedRedirectThenRedirectsAndNoSi
 		assertThat(result.getSigAlg()).isNull();
 		assertThat(result.getSignature()).isNull();
 		assertThat(result.getBinding()).isEqualTo(Saml2MessageBinding.REDIRECT);
+		assertThat(result.getId()).isNotEmpty();
 	}
 
 	@Test
@@ -98,7 +100,9 @@ public void resolveAuthenticationRequestWhenSignedThenCredentialIsRequired() {
 		RelyingPartyRegistration registration = TestRelyingPartyRegistrations.noCredentials()
 				.assertingPartyDetails((party) -> party.verificationX509Credentials((c) -> c.add(credential))).build();
 		OpenSamlAuthenticationRequestResolver resolver = authenticationRequestResolver(registration);
-		assertThatExceptionOfType(Saml2Exception.class).isThrownBy(() -> resolver.resolve(request, null));
+		assertThatExceptionOfType(Saml2Exception.class)
+				.isThrownBy(() -> resolver.resolve(request, (r, authnRequest) -> {
+				}));
 	}
 
 	@Test
@@ -122,6 +126,7 @@ public void resolveAuthenticationRequestWhenUnsignedPostThenOnlyPosts() {
 		assertThat(result.getRelayState()).isNotNull();
 		assertThat(result.getBinding()).isEqualTo(Saml2MessageBinding.POST);
 		assertThat(new String(Saml2Utils.samlDecode(result.getSamlRequest()))).doesNotContain("Signature");
+		assertThat(result.getId()).isNotEmpty();
 	}
 
 	@Test
@@ -144,6 +149,7 @@ public void resolveAuthenticationRequestWhenSignedPostThenSignsAndPosts() {
 		assertThat(result.getRelayState()).isNotNull();
 		assertThat(result.getBinding()).isEqualTo(Saml2MessageBinding.POST);
 		assertThat(new String(Saml2Utils.samlDecode(result.getSamlRequest()))).contains("Signature");
+		assertThat(result.getId()).isNotEmpty();
 	}
 
 	@Test
@@ -154,12 +160,14 @@ public void resolveAuthenticationRequestWhenSHA1SignRequestThenSigns() {
 				(party) -> party.signingAlgorithms((algs) -> algs.add(SignatureConstants.ALGO_ID_SIGNATURE_RSA_SHA1)))
 				.build();
 		OpenSamlAuthenticationRequestResolver resolver = authenticationRequestResolver(registration);
-		Saml2RedirectAuthenticationRequest result = resolver.resolve(request, null);
+		Saml2RedirectAuthenticationRequest result = resolver.resolve(request, (r, authnRequest) -> {
+		});
 		assertThat(result.getSamlRequest()).isNotEmpty();
 		assertThat(result.getRelayState()).isNotNull();
 		assertThat(result.getSigAlg()).isEqualTo(SignatureConstants.ALGO_ID_SIGNATURE_RSA_SHA1);
 		assertThat(result.getSignature()).isNotNull();
 		assertThat(result.getBinding()).isEqualTo(Saml2MessageBinding.REDIRECT);
+		assertThat(result.getId()).isNotEmpty();
 	}
 
 	private OpenSamlAuthenticationRequestResolver authenticationRequestResolver(RelyingPartyRegistration registration) {