Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spring-javaformat checkstyle and formatting #8945

Closed
philwebb opened this issue Aug 6, 2020 · 1 comment
Closed

Add spring-javaformat checkstyle and formatting #8945

philwebb opened this issue Aug 6, 2020 · 1 comment
Assignees
@rwinch
Labels
status: duplicate A duplicate of another issue type: enhancement A general enhancement

Comments

@philwebb
Copy link
Member

philwebb commented Aug 6, 2020

https://github.com/spring-io/spring-javaformat/ provides checkstyle and automatic source formatting for Spring Project. This issue is to discuss how it might be applied to spring-security.
@philwebb philwebb added status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement labels Aug 6, 2020
rwinch pushed a commit that referenced this issue Aug 24, 2020
@philwebb @rwinch
Polish spring-security-rsocket main code
e8094b8 
Manually polish `spring-security-rsocket` following the formatting
and checkstyle fixes.

Issue gh-8945
rwinch pushed a commit that referenced this issue Aug 24, 2020
@philwebb @rwinch
Polish spring-security-saml2 main code
1f03608 
Manually polish `spring-security-saml2` following the formatting
and checkstyle fixes.

Issue gh-8945
rwinch pushed a commit that referenced this issue Aug 24, 2020
@philwebb @rwinch
Polish spring-security-taglibs main code
2ca6256 
Manually polish `spring-security-taglibs` following the formatting
and checkstyle fixes.

Issue gh-8945
rwinch pushed a commit that referenced this issue Aug 24, 2020
@philwebb @rwinch
Polish spring-security-test main code
ef951ba 
Manually polish `spring-security-test` following the formatting
and checkstyle fixes.

Issue gh-8945
rwinch pushed a commit that referenced this issue Aug 24, 2020
@philwebb @rwinch
Polish spring-security-web main code
5bdd757 
Manually polish `spring-security-web` following the formatting
and checkstyle fixes.

Issue gh-8945
rwinch pushed a commit that referenced this issue Aug 24, 2020
@philwebb @rwinch
Remove blank lines from all tests
a5aa6b3 
Remove all blank lines from test code so that test methods are
visually grouped together. This generally helps to make the test
classes easer to scan, however, the "given" / "when" / "then"
blocks used by some tests are now not as easy to discern.

Issue gh-8945
rwinch pushed a commit that referenced this issue Aug 24, 2020
@philwebb @rwinch
Remove incorrect AssertJ imports
0a3eeb9 
Fix a few tests that were accidentally importing incorrect AssertJ
classes.

Issue gh-8945
rwinch pushed a commit that referenced this issue Aug 24, 2020
@philwebb @rwinch
Use assertThatObject to save casting
2f8e835 
Update tests that use `assertThat((Object) ...)` to use the convenience
`assertThatObject(...)` method instead.

Issue gh-8945
rwinch pushed a commit that referenced this issue Aug 24, 2020
@philwebb @rwinch
Move @mock annotations
1e840cc 
Update a couple of tests to use the more traditional `@Mock` annotation
placement.

Issue gh-8945
rwinch pushed a commit that referenced this issue Aug 24, 2020
@philwebb @rwinch
Use assertThat instead of Java assert
ef8f113 
Fix `DefaultSavedRequestMixinTests` so that `assertThat` is used rather
than Java's `assert` keyword.

Issue gh-8945
rwinch pushed a commit that referenced this issue Aug 24, 2020
@philwebb @rwinch
Migrate to assertThatExceptionOfType
319d336 
Consistently use `assertThatExceptionOfType(...).isThrownBy(...)`
rather than `assertThatCode` or `assertThatThrownBy`. This aligns with
Spring Boot and Spring Cloud. It also allows the convenience
`assertThatIllegalArgument` and `assertThatIllegalState` methods to
be used.

Issue gh-8945
rwinch added a commit that referenced this issue Aug 24, 2020
@rwinch
Fix imports of AuthenticationPayloadExchangeConverter
28817e6 
Issue gh-8945
rwinch added a commit that referenced this issue Aug 24, 2020
@rwinch
Polish acl format
e3dd8d2 
Issue gh-8945
rwinch added a commit that referenced this issue Aug 24, 2020
@rwinch
Polish config format
254f2e2 
Issue gh-8945
rwinch added a commit that referenced this issue Aug 24, 2020
@rwinch
Polish core format
4fd67b4 
Issue gh-8945
rwinch added a commit that referenced this issue Aug 24, 2020
@rwinch
Polish crypto format
a662a55 
Issue gh-8945
rwinch added a commit that referenced this issue Aug 24, 2020
@rwinch
Polish itest format
95bc670 
Issue gh-8945
rwinch added a commit that referenced this issue Aug 24, 2020
@rwinch
Polish messaging format
38aae7f 
Issue gh-8945
rwinch added a commit that referenced this issue Aug 24, 2020
@rwinch
Polish oauth-client format
dc47a75 
Issue gh-8945
rwinch added a commit that referenced this issue Aug 24, 2020
@rwinch
Polish oauth2-core format
a729d24 
Issue gh-8945
rwinch added a commit that referenced this issue Aug 24, 2020
@rwinch
Polish oauth2-jose format
d5ae433 
Issue gh-8945
rwinch added a commit that referenced this issue Aug 24, 2020
@rwinch
Polish oauth2-resource-server format
36ae1fe 
Issue gh-8945
rwinch added a commit that referenced this issue Aug 24, 2020
@rwinch
Merge Formatting Changes
2abf59b 
Issue gh-8945
@rwinch
Copy link
Member

rwinch commented Sep 9, 2020

Closing in favor of gh-8946

@rwinch rwinch closed this as completed Sep 9, 2020
@rwinch rwinch added status: duplicate A duplicate of another issue and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 9, 2020
@rwinch rwinch self-assigned this Sep 9, 2020
jgrandja added a commit that referenced this issue Sep 9, 2020
@jgrandja
Polish "Add Spring Checkstyle with all checks disabled"
94bc197 
Commit aea0fea

Issue gh-8945
@eleftherias eleftherias mentioned this issue Dec 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwinch rwinch

Labels
status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rwinch @philwebb