-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add Spring Checkstyle with all checks disabled
Introduce checkstyle rules from spring-javaformat, but keep them disabled so that fixes can be introduced one commit at a time. Issue gh-8945
- Loading branch information
Showing
5 changed files
with
69 additions
and
84 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
<?xml version="1.0"?> | ||
<!DOCTYPE suppressions PUBLIC | ||
"-//Checkstyle//DTD SuppressionFilter Configuration 1.2//EN" | ||
"https://checkstyle.org/dtds/suppressions_1_2.dtd"> | ||
<suppressions> | ||
<suppress files=".*" checks="AnnotationUseStyle" /> | ||
<suppress files=".*" checks="ArrayTypeStyle" /> | ||
<suppress files=".*" checks="AtclauseOrder" /> | ||
<suppress files=".*" checks="AvoidStarImport" /> | ||
<suppress files=".*" checks="EmptyBlock" /> | ||
<suppress files=".*" checks="FinalClass" /> | ||
<suppress files=".*" checks="InnerAssignment" /> | ||
<suppress files=".*" checks="InnerTypeLast" /> | ||
<suppress files=".*" checks="InterfaceIsType" /> | ||
<suppress files=".*" checks="JavadocMethod" /> | ||
<suppress files=".*" checks="JavadocStyle" /> | ||
<suppress files=".*" checks="JavadocTagContinuationIndentation" /> | ||
<suppress files=".*" checks="JavadocType" /> | ||
<suppress files=".*" checks="JavadocVariable" /> | ||
<suppress files=".*" checks="ModifierOrder" /> | ||
<suppress files=".*" checks="MultipleVariableDeclarations" /> | ||
<suppress files=".*" checks="MutableException" /> | ||
<suppress files=".*" checks="NeedBraces" /> | ||
<suppress files=".*" checks="NestedIfDepth" /> | ||
<suppress files=".*" checks="NewlineAtEndOfFile" /> | ||
<suppress files=".*" checks="NonEmptyAtclauseDescription" /> | ||
<suppress files=".*" checks="NoWhitespaceBefore" /> | ||
<suppress files=".*" checks="OneTopLevelClass" /> | ||
<suppress files=".*" checks="ParenPad" /> | ||
<suppress files=".*" checks="RedundantImport" /> | ||
<suppress files=".*" checks="RegexpSinglelineJava" /> | ||
<suppress files=".*" checks="RequireThis" /> | ||
<suppress files=".*" checks="SimplifyBooleanExpression" /> | ||
<suppress files=".*" checks="SimplifyBooleanReturn" /> | ||
<suppress files=".*" checks="SpringAvoidStaticImport" /> | ||
<suppress files=".*" checks="SpringCatch" /> | ||
<suppress files=".*" checks="SpringHeader" /> | ||
<suppress files=".*" checks="SpringHideUtilityClassConstructor" /> | ||
<suppress files=".*" checks="SpringImportOrder" /> | ||
<suppress files=".*" checks="SpringJavadoc" /> | ||
<suppress files=".*" checks="SpringLambda" /> | ||
<suppress files=".*" checks="SpringMethodOrder" /> | ||
<suppress files=".*" checks="SpringMethodVisibility" /> | ||
<suppress files=".*" checks="SpringTernary" /> | ||
<suppress files=".*" checks="WhitespaceAfter" /> | ||
<suppress files=".*" checks="WhitespaceAround" /> | ||
</suppressions> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,51 +1,11 @@ | ||
<?xml version="1.0"?> | ||
<!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.3//EN" | ||
"https://www.puppycrawl.com/dtds/configuration_1_3.dtd"> | ||
<module name="Checker"> | ||
<!-- Suppressions --> | ||
<!DOCTYPE module PUBLIC | ||
"-//Checkstyle//DTD Checkstyle Configuration 1.3//EN" | ||
"https://checkstyle.org/dtds/configuration_1_3.dtd"> | ||
<module name="com.puppycrawl.tools.checkstyle.Checker"> | ||
<module name="SuppressionFilter"> | ||
<property name="file" value="${config_loc}/suppressions.xml"/> | ||
<property name="file" | ||
value="${config_loc}/checkstyle-suppressions.xml" /> | ||
</module> | ||
|
||
<!-- Root Checks --> | ||
<module name="RegexpHeader"> | ||
<property name="headerFile" value="${config_loc}/header.txt"/> | ||
<property name="fileExtensions" value="java"/> | ||
</module> | ||
|
||
<!-- Root Checks --> | ||
<module name="TreeWalker"> | ||
<!-- Annotations --> | ||
<module name="MissingOverrideCheck" /> | ||
|
||
<!-- Coding --> | ||
<module name="EmptyStatementCheck" /> | ||
<module name="RedundantModifier" /> | ||
|
||
<!-- Imports --> | ||
<module name="UnusedImportsCheck"> | ||
<property name="processJavadoc" value="true" /> | ||
</module> | ||
|
||
<!-- Regexp --> | ||
<module name="RegexpSinglelineJava"> | ||
<property name="format" value="^\t* +\t*\S"/> | ||
<property name="message" value="Line has leading space characters; indentation should be performed with tabs only."/> | ||
<property name="ignoreComments" value="true"/> | ||
</module> | ||
<module name="RegexpSinglelineJava"> | ||
<property name="maximum" value="0"/> | ||
<property name="format" value="org\.junit\.Assert\.assert"/> | ||
<property name="message" value="Please use AssertJ imports."/> | ||
<property name="ignoreComments" value="true"/> | ||
</module> | ||
<module name="Regexp"> | ||
<property name="format" value="[ \t]+$"/> | ||
<property name="illegalPattern" value="true"/> | ||
<property name="message" value="Trailing whitespace"/> | ||
</module> | ||
|
||
<!-- Whitespace --> | ||
<module name="WhitespaceAfterCheck" /> | ||
</module> | ||
</module> | ||
<module name="io.spring.javaformat.checkstyle.SpringChecks" /> | ||
</module> |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.