Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MockCookie to make use of Servlet 6.0 APIs and semantics for "attributes" #30263

Closed
wants to merge 1 commit into from
Closed

Update MockCookie to make use of Servlet 6.0 APIs and semantics for "attributes" #30263

wants to merge 1 commit into from

Conversation

justin-tay
Copy link
Contributor

Modified MockCookie to populate attributes using setAttribute.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Apr 1, 2023
@justin-tay justin-tay changed the title Update MockCookie to make use of Servlet 6.0 APIs and semantics for "attributes". Update MockCookie to make use of Servlet 6.0 APIs and semantics for "attributes" Apr 1, 2023
@justin-tay justin-tay force-pushed the mockcookie-attributes branch 3 times, most recently from 49e1e0d to 593cd97 Compare April 1, 2023 15:02
@justin-tay justin-tay force-pushed the mockcookie-attributes branch from 593cd97 to 22a172c Compare April 1, 2023 15:04
@sbrannen sbrannen self-assigned this Apr 1, 2023
@sbrannen sbrannen added in: test Issues in the test module type: enhancement A general enhancement labels Apr 1, 2023
@sbrannen sbrannen added this to the 6.0.8 milestone Apr 1, 2023
@sbrannen sbrannen removed the status: waiting-for-triage An issue we've not yet triaged or decided on label Apr 1, 2023
@sbrannen sbrannen mentioned this pull request Apr 1, 2023
Closed
@sbrannen sbrannen added the in: web Issues in web modules (web, webmvc, webflux, websocket) label Apr 1, 2023
@sbrannen sbrannen mentioned this pull request Apr 1, 2023
Closed
@sbrannen sbrannen changed the title Update MockCookie to make use of Servlet 6.0 APIs and semantics for "attributes" Update MockCookie to make use of Servlet 6.0 APIs and semantics for "attributes" Apr 1, 2023
sbrannen added a commit to sbrannen/spring-framework that referenced this pull request Apr 4, 2023
@sbrannen
Polish contribution
d1d2d59 
See spring-projectsgh-30263
sbrannen added a commit to sbrannen/spring-framework that referenced this pull request Apr 4, 2023
@sbrannen
Sync MockCookie implementations
9fb61c5 
See spring-projectsgh-30263
@sbrannen sbrannen closed this in 281736f Apr 4, 2023
@sbrannen
Copy link
Member

sbrannen commented Apr 4, 2023

This has been merged into main in 281736f and revised in d1d2d59, f9cb0eb, and 9fb61c5.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sbrannen sbrannen

Labels
in: test Issues in the test module in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.8
Development

Successfully merging this pull request may close these issues.
3 participants
@justin-tay @sbrannen @spring-projects-issues